From: Takashi Iwai <tiwai@suse.de>
To: Philipp Stanner <pstanner@redhat.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] sound/isa/wavefront: copy userspace array safely
Date: Fri, 03 Nov 2023 14:58:22 +0100 [thread overview]
Message-ID: <87pm0rszup.wl-tiwai@suse.de> (raw)
In-Reply-To: <20231102190309.50891-2-pstanner@redhat.com>
On Thu, 02 Nov 2023 20:03:10 +0100,
Philipp Stanner wrote:
>
> wavefront_fx.c utilizes memdup_user() to copy a userspace array. This
> does not check for an overflow.
There is a check above the memdup_user() call; it's at most 512
bytes.
> Use the new wrapper memdup_array_user() to copy the array more safely.
>
> Suggested-by: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Although the check is already present, it's still better to use the
new helper, so I applied the patch now.
thanks,
Takashi
next prev parent reply other threads:[~2023-11-03 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 19:03 [PATCH] sound/isa/wavefront: copy userspace array safely Philipp Stanner
2023-11-03 13:58 ` Takashi Iwai [this message]
2023-11-03 14:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm0rszup.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pstanner@redhat.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox