From: Takashi Iwai <tiwai@suse.de>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran.
Date: Thu, 19 Oct 2023 15:09:56 +0200 [thread overview]
Message-ID: <87pm1alpwb.wl-tiwai@suse.de> (raw)
In-Reply-To: <a581dd50-b3c0-4774-ad3e-0db5e4c47338@linux.intel.com>
On Thu, 19 Oct 2023 12:02:55 +0200,
Maarten Lankhorst wrote:
>
> Hey,
>
> Den 2023-10-13 kl. 11:15, skrev Takashi Iwai:
> > On Mon, 09 Oct 2023 13:54:25 +0200,
> > Maarten Lankhorst wrote:
> >> In an effort to not call sof_ops_free twice, we stopped running it when
> >> probe was aborted.
> >>
> >> Check the result of cancel_work_sync to see if this was the case.
> >>
> >> Fixes: 31bb7bd9ffee ("ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful")
> >> Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> >> Acked-by: Mark Brown <broonie@kernel.org>
> > Your Signed-off-by tag is missing.
> >
> > Could you resubmit?
> >
> >
> > thanks,
> >
> > Takashi
>
> I missed this email apparently.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Is this enough for the tooling, or do you need an actual resubmit?
That's enough, and I applied the series to for-next branch now.
thanks,
Takashi
next prev parent reply other threads:[~2023-10-19 13:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 11:54 [PATCH v7 00/13] sound: Use -EPROBE_DEFER instead of i915 module loading Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran Maarten Lankhorst
2023-10-13 9:15 ` Takashi Iwai
2023-10-19 10:02 ` Maarten Lankhorst
2023-10-19 13:09 ` Takashi Iwai [this message]
2023-10-09 11:54 ` [PATCH v7 02/13] ASoC: SOF: core: Add probe_early and remove_late callbacks Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 03/13] ASoC: SOF: Intel: hda: start splitting the probe Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 04/13] ASoC: SOF: Intel: Fix error handling in hda_init() Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 05/13] ALSA: hda: Intel: Fix error handling in azx_probe() Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 06/13] ALSA: hda: i915: Allow override of gpu binding Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 07/13] ALSA: hda: i915: Add an allow_modprobe argument to snd_hdac_i915_init Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 08/13] ALSA: hda: i915: Allow xe as match for i915_component_master_match Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 09/13] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 10/13] ALSA: hda: Intel: " Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 11/13] ASoC: Intel: Skylake: " Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 12/13] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe Maarten Lankhorst
2023-10-09 11:54 ` [PATCH v7 13/13] ALSA: hda: i915: Remove extra argument from snd_hdac_i915_init Maarten Lankhorst
2023-10-10 10:49 ` [PATCH v7 00/13] sound: Use -EPROBE_DEFER instead of i915 module loading Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm1alpwb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox