From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BF2CDB465 for ; Thu, 19 Oct 2023 13:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345763AbjJSNK1 (ORCPT ); Thu, 19 Oct 2023 09:10:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235435AbjJSNKG (ORCPT ); Thu, 19 Oct 2023 09:10:06 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE17918F for ; Thu, 19 Oct 2023 06:09:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C627B1F45B; Thu, 19 Oct 2023 13:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697720997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMdo80ym8skLmYskCwbWaL7qF0X1OubV5NErMqY/lFI=; b=w0KjVboNPlybkb1hlVjv6Q1IlhAg9QatVSIens5bxbW3z+DsESJkbSoTg3jiba8IhpGx8W w3H/24Je2YCW9xGftMUo8KVaXSBe4pS9id62LgjLRaaasIRoeFPgWUadtnjQYCts7W0R5n VqoMRSdCJyMwAZHi6Uxy/i1TxwarY0Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697720997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMdo80ym8skLmYskCwbWaL7qF0X1OubV5NErMqY/lFI=; b=7TocIZptmJBazDG/K+m299/bFxbYkpplpqitD24NOxsjK8ba5etLOKD8NiFDh2wwoOJRIY ZawAqS+BbpTyx9Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 700031357F; Thu, 19 Oct 2023 13:09:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LPNiGqUqMWUOVgAAMHmgww (envelope-from ); Thu, 19 Oct 2023 13:09:57 +0000 Date: Thu, 19 Oct 2023 15:09:56 +0200 Message-ID: <87pm1alpwb.wl-tiwai@suse.de> From: Takashi Iwai To: Maarten Lankhorst Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran. In-Reply-To: References: <20231009115437.99976-1-maarten.lankhorst@linux.intel.com> <20231009115437.99976-2-maarten.lankhorst@linux.intel.com> <87il7aopcy.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-9.98 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWELVE(0.00)[15]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.88)[99.50%] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Oct 2023 12:02:55 +0200, Maarten Lankhorst wrote: > > Hey, > > Den 2023-10-13 kl. 11:15, skrev Takashi Iwai: > > On Mon, 09 Oct 2023 13:54:25 +0200, > > Maarten Lankhorst wrote: > >> In an effort to not call sof_ops_free twice, we stopped running it when > >> probe was aborted. > >> > >> Check the result of cancel_work_sync to see if this was the case. > >> > >> Fixes: 31bb7bd9ffee ("ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful") > >> Cc: Peter Ujfalusi > >> Acked-by: Mark Brown > > Your Signed-off-by tag is missing. > > > > Could you resubmit? > > > > > > thanks, > > > > Takashi > > I missed this email apparently. > > Signed-off-by: Maarten Lankhorst > > Is this enough for the tooling, or do you need an actual resubmit? That's enough, and I applied the series to for-next branch now. thanks, Takashi