From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, "Chang S. Bae" <chang.seok.bae@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [patch V3 23/30] x86/microcode: Provide new control functions
Date: Tue, 26 Sep 2023 11:42:20 +0200 [thread overview]
Message-ID: <87pm25feyr.ffs@tglx> (raw)
In-Reply-To: <20230924065824.GNZQ/eEKAO8IaCcUJU@fat_crate.local>
On Sun, Sep 24 2023 at 08:58, Borislav Petkov wrote:
> On Tue, Sep 12, 2023 at 09:58:20AM +0200, Thomas Gleixner wrote:
>> +
>> + ret = microcode_ops->apply_microcode(cpu);
>> + this_cpu_write(ucode_ctrl.result, ret);
>> + this_cpu_write(ucode_ctrl.ctrl, SCTRL_DONE);
>
> Do that update...
>
>> +
>> + /*
>> + * If the update was successful, let the siblings run the apply()
>> + * callback. If not, tell them it's done. This also covers the
>> + * case where the CPU has uniform loading at package or system
>> + * scope implemented but does not advertise it.
>> + */
>> + if (ret == UCODE_UPDATED || ret == UCODE_OK)
>> + ctrl = SCTRL_APPLY;
>> + else
>> + ctrl = SCTRL_DONE;
>
> ... here, after having checked ret.
No. That's two different things. The write above stores the information
fir the current CPU, while this conditional constructs the command for
the siblings.
next prev parent reply other threads:[~2023-09-26 16:11 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 7:57 [patch V3 00/30] x86/microcode: Cleanup and late loading enhancements Thomas Gleixner
2023-09-12 7:57 ` [patch V3 01/30] x86/microcode/32: Move early loading after paging enable Thomas Gleixner
2023-09-13 15:06 ` Borislav Petkov
2023-09-16 9:03 ` Chang S. Bae
2023-09-17 19:17 ` Thomas Gleixner
2023-09-19 14:54 ` [patch V3a " Thomas Gleixner
2023-09-12 7:57 ` [patch V3 02/30] x86/boot/32: Disable stackprotector and tracing for mk_early_pgtbl_32() Thomas Gleixner
2023-09-18 17:12 ` Borislav Petkov
2023-09-12 7:57 ` [patch V3 03/30] x86/microcode/intel: Rip out mixed stepping support for Intel CPUs Thomas Gleixner
2023-09-25 15:19 ` Qiuxu Zhuo
2023-09-12 7:57 ` [patch V3 04/30] x86/microcode/intel: Simplify scan_microcode() Thomas Gleixner
2023-09-19 12:52 ` Borislav Petkov
2023-09-12 7:57 ` [patch V3 05/30] x86/microcode/intel: Simplify and rename generic_load_microcode() Thomas Gleixner
2023-09-12 7:57 ` [patch V3 06/30] x86/microcode/intel: Cleanup code further Thomas Gleixner
2023-09-19 14:13 ` Borislav Petkov
2023-09-12 7:57 ` [patch V3 07/30] x86/microcode/intel: Simplify early loading Thomas Gleixner
2023-09-19 14:32 ` Borislav Petkov
2023-09-19 14:57 ` Thomas Gleixner
2023-09-19 17:35 ` Thomas Gleixner
2023-09-12 7:57 ` [patch V3 08/30] x86/microcode/intel: Save the microcode only after a successful late-load Thomas Gleixner
2023-09-20 14:39 ` Borislav Petkov
2023-09-25 15:30 ` Subject: " Qiuxu Zhuo
2023-09-12 7:57 ` [patch V3 09/30] x86/microcode/intel: Switch to kvmalloc() Thomas Gleixner
2023-09-25 15:43 ` Subject: " Qiuxu Zhuo
2023-09-12 7:57 ` [patch V3 10/30] x86/microcode/intel: Unify microcode apply() functions Thomas Gleixner
2023-09-21 10:07 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 11/30] x86/microcode/intel: Rework intel_cpu_collect_info() Thomas Gleixner
2023-09-12 7:58 ` [patch V3 12/30] x86/microcode/intel: Reuse intel_cpu_collect_info() Thomas Gleixner
2023-09-21 10:42 ` Borislav Petkov
2023-09-25 10:47 ` Thomas Gleixner
2023-10-03 14:14 ` Borislav Petkov
2023-10-03 14:23 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 13/30] x86/microcode/intel: Rework intel_find_matching_signature() Thomas Gleixner
2023-09-12 7:58 ` [patch V3 14/30] x86/microcode/amd: Read revision from hardware in collect_cpu_info_amd() Thomas Gleixner
2023-09-12 7:58 ` [patch V3 15/30] x86/microcode: Remove pointless apply() invocation Thomas Gleixner
2023-09-12 7:58 ` [patch V3 16/30] x86/microcode: Get rid of the schedule work indirection Thomas Gleixner
2023-09-12 7:58 ` [patch V3 17/30] x86/microcode: Clean up mc_cpu_down_prep() Thomas Gleixner
2023-09-12 7:58 ` [patch V3 18/30] x86/microcode: Handle "nosmt" correctly Thomas Gleixner
2023-09-22 13:42 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 19/30] x86/microcode: Clarify the late load logic Thomas Gleixner
2023-09-22 15:59 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 20/30] x86/microcode: Sanitize __wait_for_cpus() Thomas Gleixner
2023-09-22 16:24 ` Borislav Petkov
2023-09-26 8:51 ` Thomas Gleixner
2023-09-27 7:56 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 21/30] x86/microcode: Add per CPU result state Thomas Gleixner
2023-09-24 6:29 ` Borislav Petkov
2023-09-26 9:09 ` Thomas Gleixner
2023-09-27 11:28 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 22/30] x86/microcode: Add per CPU control field Thomas Gleixner
2023-09-24 6:47 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 23/30] x86/microcode: Provide new control functions Thomas Gleixner
2023-09-24 6:58 ` Borislav Petkov
2023-09-26 9:42 ` Thomas Gleixner [this message]
2023-09-27 11:50 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 24/30] x86/microcode: Replace the all in one rendevouz handler Thomas Gleixner
2023-09-27 16:47 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 25/30] x86/microcode: Rendezvous and load in NMI Thomas Gleixner
2023-09-27 17:17 ` Borislav Petkov
2023-09-28 9:33 ` Thomas Gleixner
2023-09-12 7:58 ` [patch V3 26/30] x86/microcode: Protect against instrumentation Thomas Gleixner
2023-09-28 10:52 ` Borislav Petkov
2023-09-12 7:58 ` [patch V3 27/30] x86/apic: Provide apic_force_nmi_on_cpu() Thomas Gleixner
2023-09-12 7:58 ` [patch V3 28/30] x86/microcode: Handle "offline" CPUs correctly Thomas Gleixner
2023-09-12 7:58 ` [patch V3 29/30] x86/microcode: Prepare for minimal revision check Thomas Gleixner
2023-09-28 11:47 ` Borislav Petkov
2023-10-02 9:42 ` Thomas Gleixner
2023-09-12 7:58 ` [patch V3 30/30] x86/microcode/intel: Add a minimum required revision for late-loads Thomas Gleixner
2023-09-25 16:20 ` Qiuxu Zhuo
2023-09-25 17:02 ` [patch V3 00/30] x86/microcode: Cleanup and late loading enhancements Qiuxu Zhuo
2023-09-28 12:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm25feyr.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox