From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52532C7EE23 for ; Mon, 5 Jun 2023 07:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbjFEHjR (ORCPT ); Mon, 5 Jun 2023 03:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbjFEHjP (ORCPT ); Mon, 5 Jun 2023 03:39:15 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22286AD; Mon, 5 Jun 2023 00:39:14 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2DC121AF9; Mon, 5 Jun 2023 07:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685950752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jo1q+EVjn19uDq4zjiSV84GIoMoRkmgfMQr5y8Y0sh4=; b=Ljr/3IJfvzKGbcl04cpIA/S5nywdRuAjIc/pvUU0xLFFw2jLIHkleajo3IbzBWKOzh/+5p SXnF7bnTtn2EoxxNu9BNaJ6FVCa5hPpHEWfYHtfrnq/m6Y7SogBURuKw1TiqmMIs77eX7u 9jPjGrKjtpoBBZ+k95zypyxYTxEnyj8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685950752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jo1q+EVjn19uDq4zjiSV84GIoMoRkmgfMQr5y8Y0sh4=; b=LIduBt30SdkWJwxcgODlfTdahkIDG7jqbF+O1BH3nWgma9i/L46CLyjujoL+WcVUitJ8Wk hFDcca92QFuM1bCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A11B3139C7; Mon, 5 Jun 2023 07:39:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id egd0JiCRfWT7cAAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:39:12 +0000 Date: Mon, 05 Jun 2023 09:39:12 +0200 Message-ID: <87pm6aicin.wl-tiwai@suse.de> From: Takashi Iwai To: Joakim Tjernlund Cc: "gregkh@linuxfoundation.org" , "perex@perex.cz" , "michael@ralston.id.au" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] ALSA: usb-audio: Fix "cannot set freq 48000 to ep 0x3" msgs In-Reply-To: <202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com> References: <20230601131116.1014250-1-joakim.tjernlund@infinera.com> <202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Jun 2023 16:28:05 +0200, Joakim Tjernlund wrote: > > Adding Michael Ralston > > He did have problems with his behringer UMC404HD device when this whole seq. was removed. > Ralston, can you try if the below change affects your device? Sorry for the late reaction, as I've been off in the last weeks. The code sequence there seems pretty sensitive, and swapping or dropping the call might break things easily on certain devices, unfortunately. So, I guess we can't take the patch as is. If any, we need to fiddle the call order depending on the device quirk or such. I guess we may try to fit with the existing quirk flag. Let me check it later. thanks, Takashi > Jocke > > On Thu, 2023-06-01 at 15:11 +0200, Joakim Tjernlund wrote: > > On some USB speaker devices(Jabra/Logitech) we see above error > > msg when connecting device to computer and kernel is probing the device. > > > > Moving the snd_usb_init_sample_rate() to after usb_set_interface() makes > > the error go away. > > > > Signed-off-by: Joakim Tjernlund > > Cc: stable@vger.kernel.org > > --- > > sound/usb/stream.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > > index f10f4e6d3fb8..d9ac8663a48b 100644 > > --- a/sound/usb/stream.c > > +++ b/sound/usb/stream.c > > @@ -1226,8 +1226,8 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, > > /* try to set the interface... */ > > usb_set_interface(chip->dev, iface_no, 0); > > snd_usb_init_pitch(chip, fp); > > - snd_usb_init_sample_rate(chip, fp, fp->rate_max); > > usb_set_interface(chip->dev, iface_no, altno); > > + snd_usb_init_sample_rate(chip, fp, fp->rate_max); > > } > > return 0; > > } >