From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Victor Hassan <victor@allwinnertech.com>,
fweisbec@gmail.com, mingo@kernel.org, jindong.yue@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tick/broadcast: Do not set oneshot_mask except was_periodic was true
Date: Thu, 04 May 2023 00:53:52 +0200 [thread overview]
Message-ID: <87pm7h3u2n.ffs@tglx> (raw)
In-Reply-To: <ZFLftU4sEgeEaRJe@lothringen>
On Thu, May 04 2023 at 00:27, Frederic Weisbecker wrote:
> On Tue, May 02, 2023 at 02:38:57PM +0200, Thomas Gleixner wrote:
>> Updated patch below.
>>
>> Thanks,
>
> Looks good from my layperson's eyes, just a doubt about a comment below:
>
>> +
>> + /*
>> + * When switching from periodic to oneshot mode arm the broadcast
>> + * device for the next tick.
>> + *
>> + * If the broadcast device has been replaced in oneshot mode and
>> + * the oneshot broadcast mask is not empty, then arm it to expire
>> + * immediately in order to reevaluate the next expiring timer.
>> + * nexttick is 0 and therefore in the past which will cause the
>
> Is nexttick really in the past? It's set to tick_next_period...
Only in the non-replacement, i.e. the 'from_periodic' codepath, no?
Thanks,
tglx
next prev parent reply other threads:[~2023-05-03 22:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 0:34 [PATCH v2] tick/broadcast: Do not set oneshot_mask except was_periodic was true Victor Hassan
2023-04-15 21:01 ` Thomas Gleixner
2023-04-17 13:28 ` Frederic Weisbecker
2023-04-17 15:02 ` Frederic Weisbecker
2023-04-18 8:50 ` Thomas Gleixner
2023-04-18 9:09 ` Thomas Gleixner
2023-04-19 13:36 ` Frederic Weisbecker
2023-04-21 21:32 ` Thomas Gleixner
2023-05-02 11:19 ` Frederic Weisbecker
2023-05-02 12:38 ` Thomas Gleixner
2023-05-03 22:27 ` Frederic Weisbecker
2023-05-03 22:53 ` Thomas Gleixner [this message]
2023-05-04 7:50 ` Frederic Weisbecker
2023-05-06 16:40 ` [PATCH v3] tick/broadcast: Make broadcast device replacement work correctly Thomas Gleixner
2023-05-08 21:27 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner
2023-05-06 12:09 ` [PATCH v2] tick/broadcast: Do not set oneshot_mask except was_periodic was true Victor Hassan
2023-04-23 14:16 ` Victor Hassan
2023-04-24 18:28 ` Thomas Gleixner
2023-04-24 18:31 ` Thomas Gleixner
2023-04-26 2:50 ` Victor Hassan
2023-05-05 1:46 ` Victor Hassan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm7h3u2n.ffs@tglx \
--to=tglx@linutronix.de \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jindong.yue@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=victor@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox