Re: Linux 6.3-rc3

Nathan Chancellor
2023-03-20T19:04:34Z

On Mon, Mar 20, 2023 at 11:49:55AM -0700, Linus Torvalds wrote:
> On Mon, Mar 20, 2023 at 11:26 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Hmm. I do my arm64 allmodconfig builds with gcc, and I'm surprised
> > that gcc doesn't warn about this.
>
> Side note: I'm also wondering why that TEGRA_HOST1X config has that
> ARM dependency in
>
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>
> because it seems to build just fine at least on x86-64 if I change it to be just
>
> depends on ARCH_TEGRA || COMPILE_TEST
>
> ie there seems to be nothing ARM-specific in there.
>
> Limiting it to just the tegra platform by default makes 100% sense,
> but that "only do compile-testing on ARM" seems a bit bogus.
>
> That limit goes back to forever (commit 6f44c2b5280f: "gpu: host1x:
> Increase compile test coverage" back in Nov 2013), so maybe things
> didn't use to work as well back in the dark ages?
>
> None of this explains why gcc didn't catch it, but at least allowing
> the build on x86-64 would likely have made it easier for people to see
> clang catching this.

I did see a patch fly by to fix that:

https://lore.kernel.org/20230316082035.567520-3-christian.koenig@amd.com/

It seems like the DRM_TEGRA half of it is broken though:

https://lore.kernel.org/202303170635.A2RsQ1Wu-lkp@intel.com/

Cheers,
Nathan