* [PATCH] ALSA: drivers: Remove the unused variable portman_read_data
@ 2023-03-17 6:33 Jiapeng Chong
2023-03-19 8:06 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2023-03-17 6:33 UTC (permalink / raw)
To: perex; +Cc: tiwai, alsa-devel, linux-kernel, Jiapeng Chong, Abaci Robot
Variable portman_read_data is not effectively used, so delete it.
sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/drivers/portman2x4.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index 52a656735365..41b46f9ae731 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -192,11 +192,6 @@ static inline u8 portman_read_status(struct portman *pm)
return parport_read_status(pm->pardev->port);
}
-static inline u8 portman_read_data(struct portman *pm)
-{
- return parport_read_data(pm->pardev->port);
-}
-
static inline void portman_write_data(struct portman *pm, u8 value)
{
parport_write_data(pm->pardev->port, value);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read_data
2023-03-17 6:33 [PATCH] ALSA: drivers: Remove the unused variable portman_read_data Jiapeng Chong
@ 2023-03-19 8:06 ` Takashi Iwai
2023-03-19 8:12 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2023-03-19 8:06 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: perex, tiwai, alsa-devel, linux-kernel, Abaci Robot
On Fri, 17 Mar 2023 07:33:38 +0100,
Jiapeng Chong wrote:
>
> Variable portman_read_data is not effectively used, so delete it.
>
> sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read_data
2023-03-19 8:06 ` Takashi Iwai
@ 2023-03-19 8:12 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2023-03-19 8:12 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: perex, tiwai, alsa-devel, linux-kernel, Abaci Robot
On Sun, 19 Mar 2023 09:06:05 +0100,
Takashi Iwai wrote:
>
> On Fri, 17 Mar 2023 07:33:38 +0100,
> Jiapeng Chong wrote:
> >
> > Variable portman_read_data is not effectively used, so delete it.
> >
> > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Thanks, applied now.
... and now I see Tom's patch removing one more unused one, so I took
Tom's fix instead of yours.
https://lore.kernel.org/r/20230318135229.1685266-1-trix@redhat.com
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-19 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-17 6:33 [PATCH] ALSA: drivers: Remove the unused variable portman_read_data Jiapeng Chong
2023-03-19 8:06 ` Takashi Iwai
2023-03-19 8:12 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox