* [PATCH] efitools: Include <strings.h> for the strcasecmp function
@ 2022-12-14 21:30 Florian Weimer
2022-12-14 21:43 ` Lukas Wunner
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-12-14 21:30 UTC (permalink / raw)
To: linux-efi, linux-kernel
Otherwise, an implicit function declaration is the result, and the
code may fail to compile with future compilers.
---
efi-updatevar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/efi-updatevar.c b/efi-updatevar.c
index 4247105..033d938 100644
--- a/efi-updatevar.c
+++ b/efi-updatevar.c
@@ -11,6 +11,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
Related to:
<https://fedoraproject.org/wiki/Changes/PortingToModernC>
<https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] efitools: Include <strings.h> for the strcasecmp function
2022-12-14 21:30 [PATCH] efitools: Include <strings.h> for the strcasecmp function Florian Weimer
@ 2022-12-14 21:43 ` Lukas Wunner
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Wunner @ 2022-12-14 21:43 UTC (permalink / raw)
To: Florian Weimer, James Bottomley; +Cc: linux-efi, linux-kernel
[+cc James]
On Wed, Dec 14, 2022 at 10:30:26PM +0100, Florian Weimer wrote:
> Otherwise, an implicit function declaration is the result, and the
> code may fail to compile with future compilers.
>
> ---
> efi-updatevar.c | 1 +
> 1 file changed, 1 insertion(+)
efitools appears to be maintained by James, so you may want to cc
your submissions to him.
Your patches are missing a DCO, yet existing commits in the efitools
repository have one. You may want to respin with your Signed-off-by
added.
Thanks,
Lukas
>
> diff --git a/efi-updatevar.c b/efi-updatevar.c
> index 4247105..033d938 100644
> --- a/efi-updatevar.c
> +++ b/efi-updatevar.c
> @@ -11,6 +11,7 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> +#include <strings.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> #include <unistd.h>
>
> Related to:
>
> <https://fedoraproject.org/wiki/Changes/PortingToModernC>
> <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-14 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-14 21:30 [PATCH] efitools: Include <strings.h> for the strcasecmp function Florian Weimer
2022-12-14 21:43 ` Lukas Wunner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox