From: Cornelia Huck <cohuck@redhat.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kvm@vger.kernel.org
Subject: Re: [PATCH v3] vfio/fsl-mc: Fix a typo in a message
Date: Thu, 08 Sep 2022 12:29:44 +0200 [thread overview]
Message-ID: <87pmg6rwfb.fsf@redhat.com> (raw)
In-Reply-To: <a7c1394346725b7435792628c8d4c06a0a745e0b.1662134821.git.christophe.jaillet@wanadoo.fr>
On Fri, Sep 02 2022, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> L and S are swapped in the message.
> s/VFIO_FLS_MC/VFIO_FSL_MC/
>
> Also use 'ret' instead of 'WARN_ON(ret)' to avoid a duplicated message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Changes in v3:
> * Remove WARN_ON() and WARN() and only keep dev_warn() [Diana Madalina Craciun <diana.craciun@oss.nxp.com>]
>
> Changes in v2:
> * s/comment/message/ in the subject [Cornelia Huck <cohuck@redhat.com>]
> * use WARN instead of WARN_ON+dev_warn [Jason Gunthorpe <jgg@ziepe.ca>]
> https://lore.kernel.org/all/3d2aa8434393ee8d2aa23a620e59ce1059c9d7ad.1660663440.git.christophe.jaillet@wanadoo.fr/
>
> v1:
> https://lore.kernel.org/all/2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo
> ---
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-09-08 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 16:07 [PATCH v3] vfio/fsl-mc: Fix a typo in a message Christophe JAILLET
2022-09-05 16:01 ` Diana Madalina Craciun
2022-09-08 10:29 ` Cornelia Huck [this message]
2022-09-08 20:17 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmg6rwfb.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=diana.craciun@oss.nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox