From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F034EC43334 for ; Fri, 22 Jul 2022 08:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234751AbiGVIJ5 (ORCPT ); Fri, 22 Jul 2022 04:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234256AbiGVIJz (ORCPT ); Fri, 22 Jul 2022 04:09:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0813F9B576 for ; Fri, 22 Jul 2022 01:09:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1287B8279F for ; Fri, 22 Jul 2022 08:09:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FC48C341C6; Fri, 22 Jul 2022 08:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658477391; bh=pKpfyQutYgdosLiHPERhPzTPghrCx/waOhE7H+ePtY8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=srM2M/6lnNtVvIdzEfHt8pnpjV8LwTLPdB1a6GjK1q6WhZrw6TWKheXtOzgHe95W9 AfChiu5JXqj2VouPRnXSyTrGXFZrLe7D4/tGbhoLEozkTD/k6IGPyoQmyRGOgtyxjj 4F424gc+myn2/fncjPujRm5olJkpXVQXoti1dEvbTHbCeilhsgJntQfAXhxyvGUAR3 ON7NBmZZnLcSA11t99hi6yGipA8VY1WyAIFPBrldbjnPNbePzarPookd3fshpHPLBv nPzqzqsPyHSVDicbAzasQNka6TEhxaQM7x+OPZ+H0RLlP9UXFYkKJQKjY1P4K2bWaK e0EwRQ5UalZKQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEnjJ-009H2i-Hi; Fri, 22 Jul 2022 09:09:49 +0100 Date: Fri, 22 Jul 2022 09:09:49 +0100 Message-ID: <87pmhxy3ea.wl-maz@kernel.org> From: Marc Zyngier To: Ben Dooks Cc: Ben Dooks , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH] irqchip/mmp: fix missing extern init code In-Reply-To: <20220722080333.4ic4n3bmsxs6kyyq@hetzy.fluff.org> References: <20220721215147.468971-1-ben-linux@fluff.org> <87sfmty4ou.wl-maz@kernel.org> <20220722080333.4ic4n3bmsxs6kyyq@hetzy.fluff.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ben@fluff.org, ben-linux@fluff.org, linux-kernel@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jul 2022 09:03:33 +0100, Ben Dooks wrote: > > On Fri, Jul 22, 2022 at 08:41:53AM +0100, Marc Zyngier wrote: > > On Thu, 21 Jul 2022 22:51:47 +0100, > > Ben Dooks wrote: > > > > > > The functions icu_init_irq and mmp2_init_icu are exported > > > from this code, so declare them in the header file to avoid > > > the following sparse warnings: > > > $ git grep -E "icu_init_irq|mmp2_init_icu" > > arch/arm/mach-mmp/mmp2.c: mmp2_init_icu(); > > arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void); > > arch/arm/mach-mmp/pxa168.c: icu_init_irq(); > > arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void); > > arch/arm/mach-mmp/pxa910.c: icu_init_irq(); > > arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void); > > drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void) > > drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void) > > > > If you are going to fix this, please fix it sensibly. > > Ok, didn't realise these where not being built my the v7_multi defconfig. > Should this all go into one patch or do the arch/arm bits need to go via > some arm tree? One single patch please, which I'll queue directly. M. -- Without deviation from the norm, progress is not possible.