From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alexey Gladkov <legion@kernel.org>
Subject: Re: [PATCH 1/2] ucount: Fix atomic_long_inc_below argument type
Date: Fri, 15 Jul 2022 13:23:24 -0500 [thread overview]
Message-ID: <87pmi6z143.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <20220713155405.80663-2-ubizjak@gmail.com> (Uros Bizjak's message of "Wed, 13 Jul 2022 17:54:04 +0200")
Uros Bizjak <ubizjak@gmail.com> writes:
> The type of u argument of atomic_long_inc_below should be long
> to avoid unwanted truncation to int.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Fixes: f9c82a4ea89c ("Increase size of ucounts to atomic_long_t")
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
> kernel/ucount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/ucount.c b/kernel/ucount.c
> index 06ea04d44685..974ac1585009 100644
> --- a/kernel/ucount.c
> +++ b/kernel/ucount.c
> @@ -216,7 +216,7 @@ void put_ucounts(struct ucounts *ucounts)
> }
> }
>
> -static inline bool atomic_long_inc_below(atomic_long_t *v, int u)
> +static inline bool atomic_long_inc_below(atomic_long_t *v, long u)
> {
> long c, old;
> c = atomic_long_read(v);
next prev parent reply other threads:[~2022-07-15 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 15:54 [PATCH 0/2] ucount: Fix and improve atomic_long_inc_below Uros Bizjak
2022-07-13 15:54 ` [PATCH 1/2] ucount: Fix atomic_long_inc_below argument type Uros Bizjak
2022-07-15 18:23 ` Eric W. Biederman [this message]
2022-07-13 15:54 ` [PATCH 2/2] ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below Uros Bizjak
2022-07-15 18:25 ` [PATCH 0/2] ucount: Fix and improve atomic_long_inc_below Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmi6z143.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox