From: John Ogness <john.ogness@linutronix.de>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
paulus@samba.org, Nicholas Piggin <npiggin@gmail.com>,
ldufour@linux.ibm.com, pmladek@suse.com, Julia.Lawall@inria.fr,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lance@osuosl.org, "Paul E. McKenney" <paulmck@kernel.org>,
rcu <rcu@vger.kernel.org>
Subject: Re: [PATCH linux-next] powerpc: use raw_smp_processor_id in arch_touch_nmi_watchdog
Date: Thu, 14 Jul 2022 13:52:37 +0206 [thread overview]
Message-ID: <87pmi77w82.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <CAABZP2x-OiwX7-nRvdPz0NU1D5kgUoL4MQOgTqLK1KgLcrZ5DA@mail.gmail.com>
On 2022-07-14, Zhouyi Zhou <zhouzhouyi@gmail.com> wrote:
> Thank John for correcting me ;-)
After looking more closely, I do not think disabling migration is the
correct fix either.
The per-cpu variable @wd_timer_tb is written from 2 functions:
- watchdog_timer_interrupt() <-- irq handler
- arch_touch_nmi_watchdog() <-- called from preemptible
Since watchdog_timer_interrupt() is called from irq context, I expect
that interrupts need to be disabled for the update in
arch_touch_nmi_watchdog(). Perhaps a using a per-cpu local_lock_t with
local_lock_irqsave() to protect write access to @wd_timer_tb?
John Ogness
prev parent reply other threads:[~2022-07-14 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 1:31 [PATCH linux-next] powerpc: use raw_smp_processor_id in arch_touch_nmi_watchdog Zhouyi Zhou
2022-07-14 9:25 ` John Ogness
2022-07-14 10:01 ` Zhouyi Zhou
2022-07-14 11:46 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmi77w82.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=Julia.Lawall@inria.fr \
--cc=benh@kernel.crashing.org \
--cc=lance@osuosl.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=paulus@samba.org \
--cc=pmladek@suse.com \
--cc=rcu@vger.kernel.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox