From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yang Li <yang.lee@linux.alibaba.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ptrace: Remove duplicated include in ptrace.c
Date: Wed, 16 Mar 2022 08:35:59 -0500 [thread overview]
Message-ID: <87pmmm58ao.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <CAMuHMdXvgXAnZTGxBWyQ78LPko1f1uUhQRT6TxE1ZDHhRiT2Zw@mail.gmail.com> (Geert Uytterhoeven's message of "Wed, 16 Mar 2022 08:20:09 +0100")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Hi Yang,
>
> CC Eric
>
> On Wed, Mar 16, 2022 at 12:52 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>> Fix following includecheck warning:
>> ./arch/m68k/kernel/ptrace.c: linux/ptrace.h is included more than once.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>> --- a/arch/m68k/kernel/ptrace.c
>> +++ b/arch/m68k/kernel/ptrace.c
>> @@ -19,7 +19,6 @@
>> #include <linux/ptrace.h>
>> #include <linux/user.h>
>> #include <linux/signal.h>
>> -#include <linux/ptrace.h>
>>
>> #include <linux/uaccess.h>
>> #include <asm/page.h>
>
> This is due to commit 153474ba1a4aed0a ("ptrace: Create
> ptrace_report_syscall_{entry,exit} in ptrace.h"), which is not yet
> in the m68k tree, but only in next-20220315, so I cannot do anything
> about it before v5.18-rc1.
>
> Eric: Can you still fix this in the original commit?
Not unless it is something very serious. Replacing the commit means invalidating
testing and review. Which I would rather not do.
In this case I can merge a trivial fix to remove the duplicate. Let me
find Lang Li's patch and merge that.
Eric
prev parent reply other threads:[~2022-03-16 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 23:51 [PATCH -next] ptrace: Remove duplicated include in ptrace.c Yang Li
2022-03-16 7:20 ` Geert Uytterhoeven
2022-03-16 13:35 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmmm58ao.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=abaci@linux.alibaba.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=oleg@redhat.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox