From: Marc Zyngier <maz@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH V8 02/10] irqchip/loongson-pch-pic: Add ACPI init support
Date: Thu, 16 Dec 2021 15:06:18 +0000 [thread overview]
Message-ID: <87pmpwwpw5.wl-maz@kernel.org> (raw)
In-Reply-To: <20211216125356.632067-2-chenhuacai@loongson.cn>
On Thu, 16 Dec 2021 12:53:48 +0000,
Huacai Chen <chenhuacai@loongson.cn> wrote:
>
> We are preparing to add new Loongson (based on LoongArch, not compatible
> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> as its boot protocol, so add ACPI init support.
>
> PCH-PIC/PCH-MSI stands for "Interrupt Controller" that described in
> Section 5 of "Loongson 7A1000 Bridge User Manual". For more information
> please refer Documentation/loongarch/irq-chip-model.rst.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> drivers/irqchip/irq-loongson-pch-pic.c | 108 ++++++++++++++++++-------
> 1 file changed, 81 insertions(+), 27 deletions(-)
[...]
>
> +#ifdef CONFIG_ACPI
> +
> +struct irq_domain *pch_pic_acpi_init(struct irq_domain *parent,
> + struct acpi_madt_bio_pic *acpi_pchpic)
Who is calling this? This works the opposite way from what the arm64
irqchips are doing. Why? I have the ugly feeling that this is called
from the arch code, bypassing the existing infrastructure...
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-12-16 15:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:51 [PATCH V8 00/10] irqchip: Add LoongArch-related irqchip drivers Huacai Chen
2021-12-16 12:53 ` [PATCH V8 01/10] irqchip: Adjust Kconfig for Loongson Huacai Chen
2021-12-16 12:53 ` [PATCH V8 02/10] irqchip/loongson-pch-pic: Add ACPI init support Huacai Chen
2021-12-16 15:06 ` Marc Zyngier [this message]
2021-12-17 4:45 ` Huacai Chen
2021-12-20 12:13 ` Marc Zyngier
2021-12-24 7:31 ` Huacai Chen
2021-12-24 9:51 ` Marc Zyngier
2022-01-25 4:21 ` Huacai Chen
2021-12-16 12:53 ` [PATCH V8 03/10] irqchip/loongson-pch-pic: Add suspend/resume support Huacai Chen
2021-12-16 12:53 ` [PATCH V8 04/10] irqchip/loongson-pch-msi: Add ACPI init support Huacai Chen
2021-12-16 12:53 ` [PATCH V8 05/10] irqchip/loongson-htvec: " Huacai Chen
2021-12-16 12:53 ` [PATCH V8 06/10] irqchip/loongson-htvec: Add suspend/resume support Huacai Chen
2021-12-16 12:53 ` [PATCH V8 07/10] irqchip/loongson-liointc: Add ACPI init support Huacai Chen
2021-12-16 12:53 ` [PATCH V8 08/10] irqchip: Add LoongArch CPU interrupt controller support Huacai Chen
2021-12-16 12:53 ` [PATCH V8 09/10] irqchip: Add Loongson Extended I/O " Huacai Chen
2021-12-16 12:53 ` [PATCH V8 10/10] irqchip: Add Loongson PCH LPC " Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmpwwpw5.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox