From: ebiederm@xmission.com (Eric W. Biederman)
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Alexander Mihalicyn <alexander@mihalicyn.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Jack Miller <millerjo@us.ibm.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrei Vagin <avagin@gmail.com>,
Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed
Date: Fri, 24 Sep 2021 11:45:07 -0500 [thread overview]
Message-ID: <87pmsxorcc.fsf@disp2133> (raw)
In-Reply-To: <00ce7bff-e432-8244-1765-12460817baab@colorfullife.com> (Manfred Spraul's message of "Thu, 23 Sep 2021 18:36:16 +0200")
Manfred Spraul <manfred@colorfullife.com> writes:
> Hi Eric,
>
> I'd like to restart the discussion, the issue should be fixed.
Agreed.
I am going to come right out and say having read through everything
my suggests were confused and wrong.
Somehow I thought the cleanups I was suggesting world result in
shm_clist only being modified from the task that owns the list.
Which would result in no need to use a per-task list.
Having looked through my suggestions again I was completely wrong.
The only useful bit I have to contribute from that original suggestion
is let's please have smallish patches that change one thing at a time.
That code is sufficiently interesting that it is way too easy to get
lost in big patches.
I am not going to discuss my broken suggestions right now because every
time I look into them I go into a rabbit hole and I don't get anything
productive done on fixing these issues, just something close and
frustrating. Apologies if I derailed your patch.
Eric
prev parent reply other threads:[~2021-09-24 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 13:22 [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed Alexander Mikhalitsyn
2021-07-06 13:22 ` [PATCH 1/2] shm: skip shm_destroy " Alexander Mikhalitsyn
2021-07-06 13:22 ` [PATCH 2/2] ipc: WARN if trying to remove ipc object which is absent Alexander Mikhalitsyn
2021-07-10 1:12 ` [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed Andrew Morton
2021-07-10 10:55 ` Alexander Mihalicyn
[not found] ` <CALgW_8VUk0us_umLncUv2DUMkOi3qixmT+YkHV4Dhpt_nNMZHw@mail.gmail.com>
2021-07-11 10:33 ` Alexander Mihalicyn
2021-07-11 11:46 ` Manfred Spraul
2021-07-12 9:54 ` Alexander Mihalicyn
2021-07-12 19:18 ` Eric W. Biederman
2021-07-12 19:27 ` Alexander Mihalicyn
2021-07-14 17:30 ` [RFC PATCH] shm: extend forced shm destroy to support objects from several IPC nses Alexander Mikhalitsyn
2021-07-21 6:32 ` Manfred Spraul
2021-07-22 18:46 ` Manfred Spraul
2021-07-30 14:52 ` Alexander Mihalicyn
2021-07-14 17:42 ` [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed Alexander Mihalicyn
2021-09-23 16:36 ` Manfred Spraul
2021-09-24 16:45 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmsxorcc.fsf@disp2133 \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=christian@brauner.io \
--cc=dave@stgolabs.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mhocko@suse.com \
--cc=millerjo@us.ibm.com \
--cc=miltonm@bga.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox