Re: [PATCH 0/2] shm: omit forced shm destroy if task IPC namespace was changed

Eric W. Biederman
2021-09-24T16:45:21Z

Manfred Spraul <manfred@colorfullife.com> writes:

> Hi Eric,
>
> I'd like to restart the discussion, the issue should be fixed.

Agreed.

I am going to come right out and say having read through everything
my suggests were confused and wrong.

Somehow I thought the cleanups I was suggesting world result in
shm_clist only being modified from the task that owns the list.
Which would result in no need to use a per-task list.

Having looked through my suggestions again I was completely wrong.

The only useful bit I have to contribute from that original suggestion
is let's please have smallish patches that change one thing at a time.

That code is sufficiently interesting that it is way too easy to get
lost in big patches.

I am not going to discuss my broken suggestions right now because every
time I look into them I go into a rabbit hole and I don't get anything
productive done on fixing these issues, just something close and
frustrating. Apologies if I derailed your patch.

Eric