From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4859C433B4 for ; Tue, 11 May 2021 07:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FCCF6192C for ; Tue, 11 May 2021 07:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230474AbhEKHPx (ORCPT ); Tue, 11 May 2021 03:15:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbhEKHPu (ORCPT ); Tue, 11 May 2021 03:15:50 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA05761926; Tue, 11 May 2021 07:14:44 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lgMbK-000cKz-MU; Tue, 11 May 2021 08:14:42 +0100 Date: Tue, 11 May 2021 08:14:42 +0100 Message-ID: <87pmxxoi71.wl-maz@kernel.org> From: Marc Zyngier To: Zou Wei Cc: , , , , , Jisheng Zhang Subject: Re: [PATCH -next] clocksource/drivers/arm_arch_timer: Make symbol 'arch_timer_rate1' static In-Reply-To: <1620715583-107670-1-git-send-email-zou_wei@huawei.com> References: <1620715583-107670-1-git-send-email-zou_wei@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: zou_wei@huawei.com, mark.rutland@arm.com, daniel.lezcano@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jisheng.Zhang@synaptics.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+ Jisheng Zhang] On Tue, 11 May 2021 07:46:23 +0100, Zou Wei wrote: > > The sparse tool complains as follows: > > drivers/clocksource/arm_arch_timer.c:67:5: warning: > symbol 'arch_timer_rate1' was not declared. Should it be static? > > This symbol is not used outside of arm_arch_timer.c, so marks it > static. It is worse than that. This variable is not used *at all*, and has been added by e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add __ro_after_init and __init"). Not sure how we missed that. Please post a patch removing this variable altogether. Thanks, M. > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/clocksource/arm_arch_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index fe1a826..800aaa9 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -64,7 +64,7 @@ struct arch_timer { > #define to_arch_timer(e) container_of(e, struct arch_timer, evt) > > static u32 arch_timer_rate __ro_after_init; > -u32 arch_timer_rate1 __ro_after_init; > +static u32 arch_timer_rate1 __ro_after_init; > static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init; > > static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = { > -- > 2.6.2 > > -- Without deviation from the norm, progress is not possible.