Re: [RFC PATCH 0/5] madvise MADV_DOEXEC

Eric W. Biederman
2020-08-03T15:31:48Z

Steven Sistare <steven.sistare@oracle.com> writes:

> On 7/30/2020 5:58 PM, ebiederm@xmission.com wrote:
>> Here is another suggestion.
>>
>> Have a very simple program that does:
>>
>> for (;;) {
>> handle = dlopen("/my/real/program");
>> real_main = dlsym(handle, "main");
>> real_main(argc, argv, envp);
>> dlclose(handle);
>> }
>>
>> With whatever obvious adjustments are needed to fit your usecase.
>>
>> That should give the same level of functionality, be portable to all
>> unices, and not require you to duplicate code. It belive it limits you
>> to not upgrading libc, or librt but that is a comparatively small
>> limitation.
>>
>>
>> Given that in general the interesting work is done in userspace and that
>> userspace has provided an interface for reusing that work already.
>> I don't see the justification for adding anything to exec at this point.
>
> Thanks for the suggestion. That is clever, and would make a fun project,
> but I would not trust it for production. These few lines are just
> the first of many that it would take to reset the environment to the
> well-defined post-exec initial conditions that all executables expect,
> and incrementally tearing down state will be prone to bugs.

Agreed.

> Getting a clean slate from a kernel exec is a much more reliable
> design.

Except you are explicitly throwing that out the window, by preserving
VMAs. You very much need to have a clean bug free shutdown to pass VMAs
reliably.

> The use case is creating long-lived apps that never go down, and the
> simplest implementation will have the fewest bugs and is the best.
> MADV_DOEXEC is simple, and does not even require a new system call,
> and the kernel already knows how to exec without bugs.

*ROFL* I wish the kernel knew how to exec things without bugs.
The bugs are hard to hit but the ones I am aware of are not straight
forward to fix.

MADV_DOEXEC is not conceptually simple. It completely violates the
guarantees that exec is known to make about the contents of the memory
of the new process. This makes it very difficult to reason about. Nor
will MADV_DOEXEC be tested very much as it has only one or two users.
Which means in the fullness of time it is likely someone will change
something that will break the implementation subtlely and the bug report
probably won't come in for 3 years, or maybe a decade. At which point
it won't be clear if the bug even can be fixed as something else might
rely on it.

What is wrong with live migration between one qemu process and another
qemu process on the same machine not work for this use case?

Just reusing live migration would seem to be the simplest path of all,
as the code is already implemented. Further if something goes wrong
with the live migration you can fallback to the existing process. With
exec there is no fallback if the new version does not properly support
the handoff protocol of the old version.

Eric