From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbdECHiO (ORCPT ); Wed, 3 May 2017 03:38:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:36008 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751014AbdECHiH (ORCPT ); Wed, 3 May 2017 03:38:07 -0400 References: <87efw7q6tm.fsf@notabene.neil.brown.name> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Nikola Pajkovsky To: NeilBrown Cc: SF Markus Elfring , linux-raid@vger.kernel.org, Shaohua Li , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/6] md: Fine-tuning for some function implementations In-reply-to: <87efw7q6tm.fsf@notabene.neil.brown.name> Date: Wed, 03 May 2017 09:38:02 +0200 Message-ID: <87pofq75lx.fsf@suse.cz> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NeilBrown writes: > On Tue, May 02 2017, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Tue, 2 May 2017 16:12:34 +0200 >> >> Some update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring (6): >> Replace seven seq_printf() calls by seq_putc() >> Replace 17 seq_printf() calls by seq_puts() > > Why does anyone care whether printf or putc/puts is used? Really it > doesn't matter *at* *all*. It could matter, but this patchset does not state it all. Does not have any perf tests and so on. f7a5f132b447 ("proc: faster /proc/*/status") 68ba0326b4e1 ("proc: much faster /proc/vmstat") > I don't object to the patch but if it would up to me I probably wouldn't > bother applying it it either. > Sometimes I just want to "print" something and I don't want to care > whether it is a constant string or a single-byte constant string, or > something more general. > I see these changes as worse than white-space fixes. > > NeilBrown > > >> Adjust four function calls together with a variable assignment >> Use seq_puts() in faulty_status() >> Adjust six function calls together with a variable assignment in faulty_status() >> Add some spaces for better code readability >> >> drivers/md/faulty.c | 48 ++++++++++++++++++++++---------------- >> drivers/md/md.c | 66 +++++++++++++++++++++++++++++------------------------ >> 2 files changed, 64 insertions(+), 50 deletions(-) >> >> -- >> 2.12.2 -- Nikola