From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751346AbdCYHwk (ORCPT ); Sat, 25 Mar 2017 03:52:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:12993 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdCYHwi (ORCPT ); Sat, 25 Mar 2017 03:52:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,218,1486454400"; d="scan'208";a="1112009553" From: Felipe Balbi To: Shuah Khan , gregkh@linuxfoundation.org, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com Cc: Shuah Khan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels In-Reply-To: References: Date: Sat, 25 Mar 2017 09:51:28 +0200 Message-ID: <87poh523r3.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Shuah Khan writes: > This patch series consists of two fixes and changes to goto labels we *NEVER* put cleanups and fixes together. > to use meaningful names. > > While working on goto label changes, I noticed put_sync calls without > successful get_sync in error legs. The first two patches are the fixes > and the rest of the patches are goto label changes. so, you mean to say that you're adding regressions because you *THOUGHT* there was a bug there, right? Read the docs ;-) -- balbi