From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122AbcGZI2g (ORCPT ); Tue, 26 Jul 2016 04:28:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49918 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbcGZI2e (ORCPT ); Tue, 26 Jul 2016 04:28:34 -0400 From: Vitaly Kuznetsov To: Stefano Stabellini Cc: Julien Grall , Juergen Gross , Andrew Cooper , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , David Vrabel , Jan Beulich , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Boris Ostrovsky , Thomas Gleixner Subject: Re: [Xen-devel] [PATCH linux v2 0/9] xen: pvhvm: support bootup on secondary vCPUs References: <1467302203-22399-1-git-send-email-vkuznets@redhat.com> <57960843.9070602@citrix.com> <87bn1lx2fd.fsf@vitty.brq.redhat.com> <70e013df-550b-3071-71fe-1a618e0a27d7@arm.com> <8737mxx0j6.fsf@vitty.brq.redhat.com> Date: Tue, 26 Jul 2016 10:28:29 +0200 In-Reply-To: (Stefano Stabellini's message of "Mon, 25 Jul 2016 12:18:24 -0700 (PDT)") Message-ID: <87poq0vm4y.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 26 Jul 2016 08:28:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefano Stabellini writes: > On Mon, 25 Jul 2016, Vitaly Kuznetsov wrote: >> >> While we're not obliged to have the same type for xen_vcpu_id on all >> arches I see no point in diverging without a reason. I can do v3 making >> the mapping uint32 > > I agree that making the mapping uint32_t would be desirable. It would > even make sense from the int types point of view in Linux. > >>and indicating the missing value as U32_MAX-1 if nobody is against the >>idea. > > Why U32_MAX-1? (int)-1 is (unsigned)U32_MAX. Even > XEN_INVALID_MAX_VCPU_ID is defined as (~0U). Yes, my bad, of course it should be U32_MAX. -- Vitaly