From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbcFUKHQ (ORCPT ); Tue, 21 Jun 2016 06:07:16 -0400 Received: from mga11.intel.com ([192.55.52.93]:38730 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcFUKGo (ORCPT ); Tue, 21 Jun 2016 06:06:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,502,1459839600"; d="asc'?scan'208";a="832276745" From: Felipe Balbi To: Arnd Bergmann Cc: Arnd Bergmann , Andy Gross , David Brown , Peter Chen , Greg Kroah-Hartman , Alan Stern , Mark Brown , Bjorn Andersson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [RFC 0/8] usb: phy: msm: various cleanups In-Reply-To: <1463606653-325131-1-git-send-email-arnd@arndb.de> References: <1463606653-325131-1-git-send-email-arnd@arndb.de> User-Agent: Notmuch/0.22+51~gcc1a6d2 (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu) Date: Tue, 21 Jun 2016 11:14:55 +0300 Message-ID: <87porbnekg.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Arnd Bergmann writes: > I stumbled over this warning last week, which showed up after I had > removed an incorrect patch from my randconfig build setup: > > drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe': > drivers/usb/phy/phy-msm-usb.c:1735:14: error: 'regs[0].consumer' may be u= sed uninitialized in this function [-Werror=3Dmaybe-uninitialized] > motg->vddcx =3D regs[0].consumer; > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ > drivers/usb/phy/phy-msm-usb.c:1736:14: error: 'regs[1].consumer' may be u= sed uninitialized in this function [-Werror=3Dmaybe-uninitialized] > motg->v3p3 =3D regs[1].consumer; > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ > drivers/usb/phy/phy-msm-usb.c:1737:14: error: 'regs[2].consumer' may be u= sed uninitialized in this function [-Werror=3Dmaybe-uninitialized] > motg->v1p8 =3D regs[2].consumer; > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ > > Having already fixed the same problem in the phy-qcom-8x16-usb.c > driver before, I tried to do the same thing here, but it turned > out to be somewhat different, and I ended up running into several > unrelated issues in the driver that I now try to fix up. > > The series is not tested beyond verifying that it no longer causes > randconfig warnings, and some patches are not entirely obvious. > In particular the ehci-msm and chipidea changes are probably a > good idea, but they actually change the behavior of the drivers > in a way that I cannot verify through inspection alone. The > last patch in the series probably requires some changes to the > devicetree files to go along with it. > > Please have a look and test this, provided the patches make sense > conceptually. > > Arnd > > Arnd Bergmann (8): > usb: phy: move msm_hsusb.h into driver > usb: ehci-msm: call usb_phy_init instead of open-coding it > usb: chipidea: msm: remove open-coded phy init > usb: phy: move TCSR driver into new file > usb: phy: msm: move register definitions into driver > usb: phy: qcom: use bulk regulator interfaces > usb: phy: msm: remove v1p8/v3p3 voltage setting > usb: phy: msm: disable regulator for remove() I managed to apply a few of these. Some didn't apply. If you can rebase on my testing/next and fix comments, then I can apply the rest. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXaPd/AAoJEIaOsuA1yqREkdkP/in7Z7CGLJXwHJItqwhiROYv lLYxioSNVPPxGnmp2//XE3zWs0wiZbBnhG/PvFAsucajlPTSvXrtVgNXA95avvxp VNLpGnd4XGbcbDWXOImwraK0dBHOQc648c6ZmNkQRSQDhTvE067CKja1hWctgY7q VoccWgXWEStQdxvOJFotG57DLJToNxLIwWT6YCNlBnfc/vF3wHmjihCyFnWmyjwB kSgNys6emOeGIdGK0oh+HPIL4Kgxe4xicxYVJTp2Ox0GY8XpeTYkwziogjeVfGfN E0whYrKf9SjJi0qUOqUkZdjQrxoVNjDDhyx3wZg9rTnm+yDmu8KZuv9QHL9Hs7KV 2ozYaE1vwmxQ8JxWID8/KvTVt87UvZE3Ztx6Y68x8g+K72CM2V4zjlzmFu7Wfoxa t0hALz4YYPB56l9L9bCoxixGwZRqoRQmybn3dBs9zmsxCEQxfb5zV2EpFq1ePM4+ vCDEgKAKXEHYPJi0yiSWDUWy50ave18anGIfF+AFAh5dN7XObb3vcokXO7vKCL2c lZY4WLq/qfnUpFrveDd3JFQtDBzaguaqVDvZ0K3ntp92StC/yMpZX6yIRrRhCa53 6v5vvF2b7rYWEeoOVyjb/5EC9Hm/fDAfxFokUdhZzlWAbnWv74si8QDXdqzoNZ9Y VLhSOqU1kX3f/V3IoLDR =M+QK -----END PGP SIGNATURE----- --=-=-=--