From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753871AbcBGLrY (ORCPT ); Sun, 7 Feb 2016 06:47:24 -0500 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:16515 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426AbcBGLrX (ORCPT ); Sun, 7 Feb 2016 06:47:23 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 07 Feb 2016 12:47:21 +0100 X-ME-IP: 109.222.219.121 From: Robert Jarzmik To: Sergei Shtylyov Cc: netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource References: <1454796693-4446-1-git-send-email-robert.jarzmik@free.fr> <56B72133.5090801@cogentembedded.com> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 07 Feb 2016 12:47:18 +0100 In-Reply-To: <56B72133.5090801@cogentembedded.com> (Sergei Shtylyov's message of "Sun, 7 Feb 2016 13:49:23 +0300") Message-ID: <87pow83fp5.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov writes: >> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse > > Fixes: tag here? Heuh no. It doesn't fix this commit, it uses a feature brought by this commit. >> + if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE) >> dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n"); >> >> irqflags |= IRQF_SHARED; > > Why not just initialize to IRQF_SHARED? > But actually you don't need this variable anymore. Yeah, makes sense. Cheers. -- Robert