From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932441AbcBAVCj (ORCPT ); Mon, 1 Feb 2016 16:02:39 -0500 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:19770 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbcBAVCh (ORCPT ); Mon, 1 Feb 2016 16:02:37 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Feb 2016 22:02:36 +0100 X-ME-IP: 109.214.175.60 From: Robert Jarzmik To: Sergei Shtylyov Cc: Nicolas Pitre , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: smc91x: propagate irq return code References: <1454280377-25697-1-git-send-email-robert.jarzmik@free.fr> <56AF514D.6010608@cogentembedded.com> <87twls5fkk.fsf@belgarion.home> <56AFC632.8070507@cogentembedded.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Feb 2016 22:02:34 +0100 In-Reply-To: <56AFC632.8070507@cogentembedded.com> (Sergei Shtylyov's message of "Mon, 1 Feb 2016 23:55:14 +0300") Message-ID: <87powg5el1.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov writes: > On 02/01/2016 11:41 PM, Robert Jarzmik wrote: > >>>> The smc91x driver doesn't honor the probe deferral mechanism when the >>>> interrupt source is not yet available, such as one provided by a gpio >>>> controller not probed. > >>> What if 'ndev->irq' does equal 0? > >> That's not possible AFAIR. > > Possible if of_irq_get() returns 0 (and it will on failure!). Ah good catch, didn't know that one. >> And yet, that test now looks weird to me. I think I'll respin the patch with a >> "if (ndev->irq < 0) {" instead of the "if (ndev->irq <= 0) {". > > Defeating Linus' PoV as a result... ;-) Well, I'd rather face the wrath of others if I'm convinced the code is more correct. And in this case you convinced me :) -- Robert