From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753839AbbJGTyx (ORCPT ); Wed, 7 Oct 2015 15:54:53 -0400 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:53762 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbbJGTyw (ORCPT ); Wed, 7 Oct 2015 15:54:52 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 07 Oct 2015 21:54:51 +0200 X-ME-IP: 90.38.170.78 From: Robert Jarzmik To: Petr Cvek , Philipp Zabel Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera References: <5609B365.4060307@tul.cz> <1443876607.4186.35.camel@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 07 Oct 2015 21:49:33 +0200 In-Reply-To: <1443876607.4186.35.camel@gmail.com> (Philipp Zabel's message of "Sat, 03 Oct 2015 14:50:07 +0200") Message-ID: <87pp0qa27m.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philipp Zabel writes: > Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: >> This patch adds support for an OV9640 camera to the HTC Magician >> machine. >> >> Signed-off-by: Petr Cvek > > Still untested, but looks good to me. I'm still reluctant to have the reset with the timings handled in the board code as I consider this should be in the camera driver code (magician_camera_reset()). Cheers. -- Robert