From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbbCBOvY (ORCPT ); Mon, 2 Mar 2015 09:51:24 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:41474 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbCBOvW (ORCPT ); Mon, 2 Mar 2015 09:51:22 -0500 Date: Mon, 02 Mar 2015 23:51:17 +0900 Message-ID: <87pp8rtpui.wl%mitake.hitoshi@gmail.com> From: Hitoshi Mitake To: Borislav Petkov Cc: X86 ML , Hitoshi Mitake , Andy Lutomirski , LKML , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo Subject: Re: [PATCH v2 00/15] x86, alternatives: Instruction padding and more robust JMPs In-Reply-To: <20150226181338.GF3314@pd.tnic> References: <1424776497-3180-1-git-send-email-bp@alien8.de> <20150226181338.GF3314@pd.tnic> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/24.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Borislav, At Thu, 26 Feb 2015 19:13:38 +0100, Borislav Petkov wrote: > > Hi all, > > So this alternatives patchset breaks perf bench mem, here are a couple > of patches ontop, you guys tell me whether it makes sense. I wanted to > make it run all memset/memcpy routines so here are a couple of patches > which do this: > > ./perf bench mem memset -l 20MB -r all > # Running 'mem/memset' benchmark: > Routine default (Default memset() provided by glibc) > # Copying 20MB Bytes ... > > 1.136000 GB/Sec > 6.026304 GB/Sec (with prefault) > Routine x86-64-unrolled (unrolled memset() in arch/x86/lib/memset_64.S) > # Copying 20MB Bytes ... > > 5.333493 GB/Sec > 5.633473 GB/Sec (with prefault) > Routine x86-64-stosq (movsq-based memset() in arch/x86/lib/memset_64.S) > # Copying 20MB Bytes ... > > 5.828484 GB/Sec > 5.851183 GB/Sec (with prefault) > Routine x86-64-stosb (movsb-based memset() in arch/x86/lib/memset_64.S) > # Copying 20MB Bytes ... > > 5.553384 GB/Sec > 5.956465 GB/Sec (with prefault) > > This way you can see all results by executing one command only with "-r > all". > > Patches coming as a reply to this message. I'm not sure I'm a suitable person for reviewing your patch, but I tested this patchset for perf bench with your latest (v2) patchset for x86 alternatives. It looks good to me. Reviewed-by: Hitoshi Mitake Thanks, Hitoshi