From: Jani Nikula <jani.nikula@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: regression: checkpatch.pl fails when called via symlink
Date: Wed, 22 Oct 2014 16:25:28 +0300 [thread overview]
Message-ID: <87ppdktewn.fsf@intel.com> (raw)
In-Reply-To: <1413980418.18654.8.camel@perches.com>
On Wed, 22 Oct 2014, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-10-22 at 13:43 +0300, Jani Nikula wrote:
>> Since commit 66b47b4a9dad00e45c049d79966de9a3a1f4d337
>> Author: Kees Cook <keescook@chromium.org>
>> Date: Mon Oct 13 15:51:57 2014 -0700
>>
>> checkpatch: look for common misspellings
>>
>> checkpatch.pl dies with
>>
>> checkpatch.pl: Can't open /path/to/spelling.txt for reading: No such file or directory
>>
>> if it's called through a symlink in /path/to/checkpatch.pl pointing at
>> the actual script.
>>
>> Please fail graciously, and just ignore spelling if you can't find
>> spelling.txt. Or better yet, follow the links if you can.
>
> I agree it should fail better, but I'm also curious.
> Why you want to use a symlink?
Simply because I think having $HOME/bin in $PATH and a symlink there is
better than the alternatives.
I don't want to add scripts to $PATH because there's so much cruft. I
don't want to copy checkpatch.pl (and now spelling.txt) because I
generally want it to stay up-to-date. I don't want to use an alias
because some maintainer scripts would break. I don't want to use a full
path because it's tedious, and potentially different on different
machines.
Reference: http://xkcd.com/1172/
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-22 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 10:43 regression: checkpatch.pl fails when called via symlink Jani Nikula
2014-10-22 12:20 ` Joe Perches
2014-10-22 13:25 ` Jani Nikula [this message]
2014-10-22 17:13 ` Joe Perches
2014-10-23 17:16 ` Jani Nikula
2014-10-23 17:29 ` [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal Joe Perches
2014-10-23 18:52 ` Kees Cook
2014-10-24 9:02 ` Andy Whitcroft
2014-10-24 9:31 ` Joe Perches
2014-10-24 10:39 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppdktewn.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox