From: "Bjørn Mork" <bjorn@mork.no>
To: Julian Andres Klode <jak@jak-linux.org>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Matthew Garrett <matthew.garrett@nebula.com>,
ibm-acpi-devel@lists.sourceforge.net (open list:THINKPAD ACPI
EXT...),
platform-driver-x86@vger.kernel.org (open list:THINKPAD ACPI
EXT...), linux-kernel@vger.kernel.org (open list)
Subject: Re: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds
Date: Tue, 05 Nov 2013 11:18:02 +0100 [thread overview]
Message-ID: <87ppqfrw2t.fsf@nemi.mork.no> (raw)
In-Reply-To: <1383601088-21177-1-git-send-email-jak@jak-linux.org> (Julian Andres Klode's message of "Mon, 4 Nov 2013 22:38:08 +0100")
Julian Andres Klode <jak@jak-linux.org> writes:
>
> +TPACPI_HANDLE(battery, root, "\\_SB.PCI0.LPC.EC.HKEY",
> + "\\_SB.PCI0.LPCB.EC.HKEY", /* X121e, T430u */
> + "\\_SB.PCI0.LPCB.H_EC.HKEY", /* L430 */
> + "\\_SB.PCI0.LPCB.EC0.HKEY", /* Edge/S series */
> + );
> +
Isn't this just the full patch to the existing "hkey_handle" for those
models? Why not just use that handle, like e.g the rfkill driver does?
Supported models could probably be autodetected by checking whether the
methods exist?
> +static struct attribute_group bat##_BAT##_attribute_group = { \
> + .name = "BAT" #_BAT, \
> + .attrs = bat##_BAT##_attributes \
> +};
Are these names guaranteed to match the ACPI battery device(s)?
> +DEFINE_BATTERY(0);
> +DEFINE_BATTERY(1);
Are there always two batteries?
Bjørn
next prev parent reply other threads:[~2013-11-05 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 21:38 [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds Julian Andres Klode
2013-11-05 10:18 ` Bjørn Mork [this message]
2013-11-05 11:52 ` Julian Andres Klode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppqfrw2t.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=jak@jak-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox