public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@infradead.org, jolsa@redhat.com, eranian@google.com,
	linux-kernel@vger.kernel.org, namhyung.kim@lge.com,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Fix sorting for 64bit entries
Date: Mon, 30 Sep 2013 16:48:25 +0900	[thread overview]
Message-ID: <87pprqoily.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1380325164-4478-1-git-send-email-andi@firstfloor.org> (Andi Kleen's message of "Fri, 27 Sep 2013 16:39:24 -0700")

Hi Andi,

On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Some of the node comparisons in hist.c dropped the upper
> 32bit by using an int variable to store the compare
> result. This broke various 64bit fields, causing
> incorrect collapsing (found for the TSX transaction field)
>
> Just use int64_t always.

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

  reply	other threads:[~2013-09-30  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 23:39 [PATCH] perf, tools: Fix sorting for 64bit entries Andi Kleen
2013-09-30  7:48 ` Namhyung Kim [this message]
2013-10-01 17:00 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pprqoily.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung.kim@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox