Re: [PATCH 5/9] mm, hugetlb: remove redundant list_empty check in gather_surplus_pages()

Joonsoo Kim
2013-07-16T01:42:14Z

On Mon, Jul 15, 2013 at 08:01:24PM +0530, Aneesh Kumar K.V wrote:
> Joonsoo Kim <iamjoonsoo.kim@lge.com> writes:
>
> > If list is empty, list_for_each_entry_safe() doesn't do anything.
> > So, this check is redundant. Remove it.
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
>
> >
> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > index a838e6b..d4a1695 100644
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -1019,10 +1019,8 @@ free:
> > spin_unlock(&hugetlb_lock);
> >
> > /* Free unnecessary surplus pages to the buddy allocator */
> > - if (!list_empty(&surplus_list)) {
> > - list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
> > - put_page(page);
> > - }
> > + list_for_each_entry_safe(page, tmp, &surplus_list, lru) {
> > + put_page(page);
> > }
>
> You can now remove '{'

Okay.
I will do that.

Thanks.

>
>
> > spin_lock(&hugetlb_lock);
> >
> > --
> > 1.7.9.5
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: email@kvack.org