public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH 0/4] fat: fix ESTALE errors
Date: Sat, 18 Aug 2012 23:09:36 +0900	[thread overview]
Message-ID: <87pq6op9zz.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20120818132524.GW23464@ZenIV.linux.org.uk> (Al Viro's message of "Sat, 18 Aug 2012 14:25:24 +0100")

Al Viro <viro@ZenIV.linux.org.uk> writes:

> On Sat, Aug 18, 2012 at 05:41:39AM -0400, Namjae Jeon wrote:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>> 
>> This patch-set eliminates the client side ESTALE errors when
>> a FAT partition exported over NFS has its dentries evicted 
>> from the cache.
>> 
>> One of the reasons for this error is lack of permanent inode 
>> numbers on FAT which makes it difficult to construct persistent 
>> file handles.This can be overcome by using the on-disk location
>> of the directory entries (i_pos) as the inode number.
>
> The hell it can.  You've just made them unstable on rename(2).

As more hint. We can't use i_pos as the inode number.

E.g. inode is unlinked but is still opened (orphaned inode), the dir
entry is free and you can create the inode on same i_pos. After that,
both inodes have same i_pos (so inode number).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2012-08-18 14:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  9:41 [PATCH 0/4] fat: fix ESTALE errors Namjae Jeon
2012-08-18 13:25 ` Al Viro
2012-08-18 14:09   ` OGAWA Hirofumi [this message]
2012-08-20  4:19     ` Namjae Jeon
2012-08-20 20:52       ` J. Bruce Fields
2012-08-21  5:19         ` Namjae Jeon
2012-08-21  6:41           ` OGAWA Hirofumi
2012-08-21 10:58             ` Namjae Jeon
2012-08-21 21:11             ` Bastien ROUCARIES
2012-08-22  6:14               ` OGAWA Hirofumi
2012-08-22  6:17                 ` OGAWA Hirofumi
2012-08-21 13:20         ` Steven J. Magnani
2012-08-21 18:02           ` Ravishankar
2012-08-20  4:21   ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pq6op9zz.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linkinjeon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox