From: Andi Kleen <andi@firstfloor.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Stefani Seibold <stefani@seibold.net>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] proc: revert to show stack information in /proc/{pid}/status
Date: Fri, 01 Jan 2010 16:49:29 +0100 [thread overview]
Message-ID: <87pr5t7rli.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100101155630.1A1E.A69D9226@jp.fujitsu.com> (KOSAKI Motohiro's message of "Fri, 1 Jan 2010 23:14:23 +0900 (JST)")
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> writes:
>
> Anyway, I revert the regresstion patch as other regression patches. if you really want
> this feature, you have three options.
>
> 1. create new /proc file instead to use /proc/pid/status.
> 2. improve performance until typical use-case don't notice regression.
> 3. change ps and other /proc related userland implementation and resubmit this patch.
>
> But even if you choose anything, You have to test both its functional and performance
> _before_ submitting kernel patch.
4. Leave everything alone (revert all the commits) and use a ptrace
based tool to get this information when you need it.
That is what I suggested during the original code review and I still think
it's the best solution for such a obscure problem.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-01 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 14:12 [PATCH] proc: revert to show stack information in /proc/{pid}/status KOSAKI Motohiro
2009-12-31 15:48 ` Stefani Seibold
2010-01-01 14:14 ` KOSAKI Motohiro
2010-01-01 15:10 ` Stefani Seibold
2010-01-01 22:05 ` Samuel Thibault
2010-01-01 22:21 ` Stefani Seibold
2010-01-02 5:53 ` KOSAKI Motohiro
2010-01-02 8:26 ` Stefani Seibold
2010-01-02 14:05 ` [PATCH] partial revert to show stack information in /proc/<pid>/status Stefani Seibold
2010-01-05 5:24 ` KOSAKI Motohiro
2010-01-02 1:42 ` [PATCH] proc: revert to show stack information in /proc/{pid}/status Andi Kleen
2010-01-01 15:49 ` Andi Kleen [this message]
2010-01-01 16:09 ` Stefani Seibold
2010-01-07 21:52 ` Andrew Morton
2010-01-08 0:21 ` KOSAKI Motohiro
2010-01-08 0:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr5t7rli.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox