From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Split wait_noreap_copyout()
Date: Mon, 11 May 2009 13:20:09 +0200 [thread overview]
Message-ID: <87prefj386.wl%vmayatsk@redhat.com> (raw)
In-Reply-To: <20090511102050.GA4648@elte.hu>
At Mon, 11 May 2009 12:20:50 +0200, Ingo Molnar wrote:
> > -static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p,
> > - pid_t pid, uid_t uid, int why, int status)
> > +static int wait_copyout(struct wait_opts *wo, struct task_struct *p,
> > + pid_t pid, uid_t uid, int why, int status, int signal)
>
> Nice cleanups. Would be nice to fix the naming here too while at it.
>
> Right now it's two verbs and a straightforward reading of it suggest
> that we 'wait for some copyout to occur', which is nonsensical and
> confusing.
>
> So please put the main action as the first verb (this is an internal
> symbol so no subsystem differentiator is needed). Something like:
>
> copy_wait_opts_to_user()
>
> ... and it becomes a whole lot easier to read. This matches the
> copy*to_user idioms we have elsewhere so it nicely wibes with the
> sound of those.
Sure, will repost with naming fixes soon.
--
wbr, Vitaly
next prev parent reply other threads:[~2009-05-11 11:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 10:12 [PATCH 0/5] wait_task_* cleanups Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 10:20 ` Ingo Molnar
2009-05-11 11:20 ` Vitaly Mayatskikh [this message]
2009-05-11 12:04 ` Christoph Hellwig
2009-05-11 12:17 ` Ingo Molnar
2009-05-11 20:47 ` Vitaly Mayatskikh
2009-05-11 21:04 ` Ingo Molnar
2009-05-20 19:03 ` Q: put_user_try & co (Was: [PATCH 1/5] Split wait_noreap_copyout()) Oleg Nesterov
2009-05-20 20:11 ` Roland McGrath
2009-05-20 20:56 ` H. Peter Anvin
2009-05-21 13:42 ` Oleg Nesterov
2009-05-20 21:14 ` Andreas Schwab
2009-05-11 12:17 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 2/5] Use wait_copyout() in wait_task_stopped() Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 3/5] Use wait_copyout() in do_wait() Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 4/5] Use wait_copyout() in wait_task_zombie() Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 5/5] Use wait_copyout() in wait_task_continued() Vitaly Mayatskikh
-- strict thread matches above, loose matches on Subject: below --
2009-05-11 13:25 [PATCH 0/5] wait_task_* cleanups V2 Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 23:45 ` Andrew Morton
2009-05-20 15:21 ` Vitaly Mayatskikh
2009-05-20 15:57 ` Oleg Nesterov
2009-05-20 20:29 ` Roland McGrath
2009-05-20 18:21 ` Ingo Molnar
2009-05-21 14:12 ` Oleg Nesterov
2009-05-21 14:35 ` Vitaly Mayatskikh
2009-06-09 15:14 ` Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prefj386.wl%vmayatsk@redhat.com \
--to=v.mayatskih@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox