From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756466AbZEKLU0 (ORCPT ); Mon, 11 May 2009 07:20:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752782AbZEKLUN (ORCPT ); Mon, 11 May 2009 07:20:13 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:40925 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbZEKLUM (ORCPT ); Mon, 11 May 2009 07:20:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; b=wxlpTERg6km6TPc+Br3UPb7IS95bfKpkTClylRRyCavT5AVIVNk45tCHQTZveSMbK6 EhIawEweZJGh+uIn1HXuB/6l9wNLnZ93d+zdhsHYWdWtMm8m+0Qt9Gm2dAPQDWNiVuSe HYuh/T2I0StwpQJRFDwrUW7xyqSr2lNZagumE= Date: Mon, 11 May 2009 13:20:09 +0200 Message-ID: <87prefj386.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: Ingo Molnar Cc: Vitaly Mayatskikh , Andrew Morton , Oleg Nesterov , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] Split wait_noreap_copyout() In-Reply-To: <20090511102050.GA4648@elte.hu> References: <1242036759-4025-1-git-send-email-v.mayatskih@gmail.com> <1242036759-4025-2-git-send-email-v.mayatskih@gmail.com> <20090511102050.GA4648@elte.hu> User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 11 May 2009 12:20:50 +0200, Ingo Molnar wrote: > > -static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p, > > - pid_t pid, uid_t uid, int why, int status) > > +static int wait_copyout(struct wait_opts *wo, struct task_struct *p, > > + pid_t pid, uid_t uid, int why, int status, int signal) > > Nice cleanups. Would be nice to fix the naming here too while at it. > > Right now it's two verbs and a straightforward reading of it suggest > that we 'wait for some copyout to occur', which is nonsensical and > confusing. > > So please put the main action as the first verb (this is an internal > symbol so no subsystem differentiator is needed). Something like: > > copy_wait_opts_to_user() > > ... and it becomes a whole lot easier to read. This matches the > copy*to_user idioms we have elsewhere so it nicely wibes with the > sound of those. Sure, will repost with naming fixes soon. -- wbr, Vitaly