From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, Milan Broz <mbroz@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ric Wheeler <rwheeler@redhat.com>,
"MASON\,CHRISTOPHER" <CHRIS.MASON@oracle.com>
Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio?
Date: Fri, 22 Aug 2008 16:45:54 +0900 [thread overview]
Message-ID: <87pro1xzkd.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20080822063823.GR20055@kernel.dk> (Jens Axboe's message of "Fri, 22 Aug 2008 08:38:24 +0200")
Jens Axboe <jens.axboe@oracle.com> writes:
>> This should be ((rw & RW_MASK) == WRITE) too? Anyway, this seems change
>> behavior of submit_bh(WRITE_BARRIER) (maybe reiserfs only), it wouldn't
>> be your intent...
>
> Yes, I believe the simpler and more correct fix is:
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 38653e3..16b2263 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2926,14 +2926,13 @@ int submit_bh(int rw, struct buffer_head * bh)
> BUG_ON(!buffer_mapped(bh));
> BUG_ON(!bh->b_end_io);
>
> - if (buffer_ordered(bh) && (rw == WRITE))
> + if (buffer_ordered(bh) && (rw & WRITE))
> rw = WRITE_BARRIER;
I see. But, umm..., this means WRITE_SYNC with barrier was deprecated?
Or typo?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2008-08-22 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 21:31 Mount ext3 with barrier=1 doesn't send real barrier bio? Milan Broz
2008-08-20 23:38 ` Eric Sandeen
2008-08-21 5:26 ` Jens Axboe
2008-08-21 10:43 ` Ric Wheeler
2008-08-21 22:23 ` OGAWA Hirofumi
2008-08-22 6:38 ` Jens Axboe
2008-08-22 7:45 ` OGAWA Hirofumi [this message]
2008-08-22 7:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pro1xzkd.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=CHRIS.MASON@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=rwheeler@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox