public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Albert D. Cahalan" <acahalan@cs.uml.edu>
Cc: linux-kernel@vger.kernel.org, chaffee@cs.berkeley.edu
Subject: Re: [patch] fat/msdos/vfat crud removal
Date: Sun, 09 Jun 2002 13:24:41 +0900	[thread overview]
Message-ID: <87ptz1dqpi.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <200206090247.g592lR3471572@saturn.cs.uml.edu>

"Albert D. Cahalan" <acahalan@cs.uml.edu> writes:

> This get rid of the old byte order macros.
> 
> diff -Naurd old/fs/fat/cache.c new/fs/fat/cache.c
> --- old/fs/fat/cache.c	Sun Jun  2 21:44:45 2002
> +++ new/fs/fat/cache.c	Sat Jun  8 17:25:48 2002
> @@ -67,13 +67,13 @@
>  	}
>  	if (sbi->fat_bits == 32) {
>  		p_first = p_last = NULL; /* GCC needs that stuff */
> -		next = CF_LE_L(((__u32 *) bh->b_data)[(first &
> +		next = le32_to_cpu(((__u32 *) bh->b_data)[(first &
>  		    (sb->s_blocksize - 1)) >> 2]);
>  		/* Fscking Microsoft marketing department. Their "32" is 28. */

Personally I think this patch makes code readable. But please don't
remove BT
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2002-06-09  4:25 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-09  2:47 [patch] fat/msdos/vfat crud removal Albert D. Cahalan
2002-06-09  4:24 ` OGAWA Hirofumi [this message]
2002-06-09  4:32 ` OGAWA Hirofumi
2002-06-09  4:46   ` Albert D. Cahalan
2002-06-09  5:07     ` OGAWA Hirofumi
2002-06-09  6:03       ` Albert D. Cahalan
2002-06-09  6:32         ` OGAWA Hirofumi
2002-06-09  7:09           ` Albert D. Cahalan
2002-06-09  7:49             ` OGAWA Hirofumi
2002-06-09  9:46             ` Dave Jones
2002-06-09 17:52               ` Eric W. Biederman
2002-06-09 18:49                 ` H. Peter Anvin
2002-06-09 19:00                 ` Thunder from the hill
2002-06-09 19:29                   ` David Woodhouse
2002-06-09 20:19                     ` Thunder from the hill
2002-06-10 13:51                       ` Eric W. Biederman
2002-06-09 21:04                   ` Albert D. Cahalan
2002-06-10 13:55                     ` Eric W. Biederman
2002-06-11 16:49                       ` Jamie Lokier
2002-06-12  6:50                         ` Eric W. Biederman
2002-06-12 11:47                           ` Thunder from the hill
2002-06-09  9:00         ` OGAWA Hirofumi
2002-06-09 13:51         ` Martin Dalecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ptz1dqpi.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=acahalan@cs.uml.edu \
    --cc=chaffee@cs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox