From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BFF83FE67C for ; Fri, 15 May 2026 09:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836400; cv=none; b=iYRbye/V0nEbF6/3CZwX1744QHzGuQN8HLqg4FSOOlXG+M/FuoSMG1i8prhl0URvIcE2A1BztytuQdQZxfVi915FPmBE5ibyE1O4UEqdPIVvoY0GQOy2CAJIgWaHUDxVA7Lf8gDXdbMIWV3s/4ZsghZQ9Gw6EWvWFGCkcxlsBaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836400; c=relaxed/simple; bh=jICEVkBTTBtnE6uHOLtQfsM0kr3AD1+MS66oe93Bfmc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=sKpysyknEpqsabRCI/t2NnPYkuPqnJfO6gOutKqDuiYNbVAKgKuwGZABOFaOxZUlhmkkn3KMFYOjzkUw7i+JtD9xivtWHSQv+QL55X/cMi5ufJUeuGI1AeHA457yH8upFMKWnVURDKqX9h2W94K/WEJ8W5zwB8avoZzm5w/6l9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bhl2e8/i; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=BDzCMh+o; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bhl2e8/i"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="BDzCMh+o" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1778836070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jICEVkBTTBtnE6uHOLtQfsM0kr3AD1+MS66oe93Bfmc=; b=bhl2e8/ih6CSGgprtPPebTFNeZcRyO3q3nzf2OnuFtw4GNaKcs/I0O7YqaAhP997yi/hck 4O0rwobsBzSja5geBbst8g9YLAWt/94vZlyFleeNHmRSdnEv1Vn0V6PfZddqsmbVEZK9y2 z5b6nVQX0mVWyAVSSHLTkIyzvyNIwwW0VZyFyPsdTvNznNdQuMXf27Hr5uEcunzl8cmKT4 GElGFgRWQCaZ2kG/4bWLIxWYnSF40ToeJb2aZYF1vsw7OdbWOXY5zHrZqoih/gxh+0tfjl tfa5deUmjbC8h434X8xApGDRxHpnPyQL87e9nqWMaQdfWoanhMnrPkMhRN0T+g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1778836070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jICEVkBTTBtnE6uHOLtQfsM0kr3AD1+MS66oe93Bfmc=; b=BDzCMh+odGXmPADC08uFJMiw9wN68rtnXfyjRnjUxhVbr8q30AL3bPq5cwGAWFg+34reBR GeXyk8U0h9db37Dw== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , Chris Down , linux-kernel@vger.kernel.org, Petr Mladek Subject: Re: [PATCH v2 2/9] printk: Rename preferred_console to preferred_dev_console In-Reply-To: <20260423130015.85175-3-pmladek@suse.com> References: <20260423130015.85175-1-pmladek@suse.com> <20260423130015.85175-3-pmladek@suse.com> Date: Fri, 15 May 2026 11:13:49 +0206 Message-ID: <87qznd6nx6.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-04-23, Petr Mladek wrote: > The preferred_consoles[] array stores information about consoles requested > via the command line, SPCR, Device Tree, or platform-specific code. > Within this array, the 'preferred_console' variable tracks the specific > index that should be associated with /dev/console (typically the last > non-braille console defined). > > The current name "preferred_console" is ambiguous and leads to confusion. > It does not clearly communicate why one console is "more preferred" than > others in the array. Furthermore, entries for Braille consoles can exist > within the preferred_consoles[] array, yet they are never associated with > /dev/console and do not receive standard printk() output. Consequently, > the 'preferred_console' index must skip these entries, which is not > immediately obvious from the name. > > Rename the variable to 'preferred_dev_console' to explicitly clarify its > role in identifying which entry is linked to /dev/console. > > The patch should not change the existing behavior. > > Signed-off-by: Petr Mladek > Acked-by: Chris Down > Acked-by: Marcos Paulo de Souza Reviewed-by: John Ogness