public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rodrigo Faria <rodrigofilipefaria@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add mute LED fixup for HP Pavilion 15-cs1xxx
Date: Mon, 04 May 2026 17:54:49 +0200	[thread overview]
Message-ID: <87qznrw4om.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260504145337.8740-1-rodrigofilipefaria@gmail.com>

On Mon, 04 May 2026 16:53:37 +0200,
Rodrigo Faria wrote:
> 
> Add a new fixup for the mute LED on the HP Pavilion 15-cs series
> using the VREF on NID 0x1b. These models will no longer fall back
> to the generic 103c:0000.

So your model has a PCI SSID *:0000?  Or what does this mean exactly?

> Signed-off-by: Rodrigo Faria <rodrigofilipefaria@gmail.com>
> ---
>  sound/hda/codecs/realtek/alc269.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index a9cd03bb7..1db72bf28 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -1669,6 +1669,20 @@ static void alc295_fixup_hp_mute_led_coefbit11(struct hda_codec *codec,
>  	}
>  }
>  
> +static void alc295_fixup_hp_pavilion_mute_led_1b(struct hda_codec *codec,
> +						 const struct hda_fixup *fix,
> +						 int action)
> +{
> +	struct alc_spec *spec = codec->spec;
> +
> +	alc269_fixup_hp_mute_led(codec, fix, action);
> +
> +	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
> +		spec->mute_led_nid = 0x1b;
> +		spec->mute_led_polarity = 0;
> +	}

Hm, the BIOS gives a wrong pin number via DMI?
This bug pattern is new.

I can take the patch, but I'd like to understand better what's going
on.


thanks,

Takashi

  reply	other threads:[~2026-05-04 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 14:53 [PATCH] ALSA: hda/realtek: Add mute LED fixup for HP Pavilion 15-cs1xxx Rodrigo Faria
2026-05-04 15:54 ` Takashi Iwai [this message]
2026-05-04 17:31   ` Rodrigo Faria
2026-05-05  9:52     ` Takashi Iwai
2026-05-05 15:27       ` Rodrigo Faria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qznrw4om.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rodrigofilipefaria@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox