From: Thomas Gleixner <tglx@linutronix.de>
To: Luigi Rizzo <lrizzo@google.com>, Marc Zyngier <maz@kernel.org>,
Luigi Rizzo <rizzo.unipi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-arch@vger.kernel.org
Subject: Re: [QUESTION] is vector_lock needed in apic_retrigger_irq() ?
Date: Tue, 17 Feb 2026 22:08:19 +0100 [thread overview]
Message-ID: <87qzqjw01o.ffs@tglx> (raw)
In-Reply-To: <CAMOZA0Kp29dCbj2KsX3XcuA77ghoxR1ANiOGdW-jDttFrYaKGw@mail.gmail.com>
On Mon, Feb 16 2026 at 21:44, Luigi Rizzo wrote:
> apic_retrigger_irq() grabs vector_lock, see code below.
>
> I am not sure if this is needed, because the function
> is called with a lock held on irqdesc, so I think the CPU and
> vector should be stable.
>
> Comments ?
You're right. Any action which would change apcid->vector has to hold
the descriptor lock.
next prev parent reply other threads:[~2026-02-17 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMOZA0Kp29dCbj2KsX3XcuA77ghoxR1ANiOGdW-jDttFrYaKGw@mail.gmail.com>
2026-02-16 20:47 ` [QUESTION] is vector_lock needed in apic_retrigger_irq() ? Luigi Rizzo
2026-02-17 21:08 ` Thomas Gleixner [this message]
2026-02-18 20:49 ` Thomas Gleixner
2026-02-18 21:14 ` Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzqjw01o.ffs@tglx \
--to=tglx@linutronix.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=maz@kernel.org \
--cc=rizzo.unipi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox