From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A3241FDA for ; Sat, 13 Dec 2025 09:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765618386; cv=none; b=HP1zkjyPsTE0hCBPRUbFYWnNxVoXptsqxqQqYaD5+WdB4BVQxqJrOdA8qhAh/Jx69y/05BvH37ZGtcLj+QBnAzQL/RlnVv1A8VZd+IS606VzX9EI2nNDZjdQuHKlAju36d+e1OIZkg0WAfQP2dGLoQrUQxd48/n20cIR50GIAiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765618386; c=relaxed/simple; bh=n7tshzJ+ZG+RWmNXpjdMpWOLYqOGzXixa7+k/RzIUOY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=HZvt3YeBQWIFMPFMgXqGcqKvylO+arjg+OJNQNhHINo/QAasOAEaR92wInSFkAUBnbdbPy5YGE/B5g1JkHaCdQXN/Y0cL48J8baK9PAnBs64hW+A2IGDx6KzlPxE2Be6XejhJY6FC9EYIJgdF3cxWsr6lOApaHI8b9bcAxWjN8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=SJ+sgMiB; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6xkBndiJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=utcedFvi; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MolW6uo3; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SJ+sgMiB"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6xkBndiJ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="utcedFvi"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MolW6uo3" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5C5B45BEA0; Sat, 13 Dec 2025 09:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765618382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HVdZ5mDPLajQKLSOWxNsmmSSDODzzWGj79xvKWatIPM=; b=SJ+sgMiBALTwhXAWAqnY0AN82/owGdRbVAVyscVoIuIXfKFO+qT0ttIDcFaS9zAabhpmpl LesxlBTMFAiimTYzXReaLqqcZtdEu+0GDGV0e9VS5XtdllGpv6suEsosppSbxs1wuMTxOz XRSzFVxK12OBZVSXlo7WkWpqnyNoWFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765618382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HVdZ5mDPLajQKLSOWxNsmmSSDODzzWGj79xvKWatIPM=; b=6xkBndiJnZAFedlGxjNejkdhnYwyK6nnobeOfCC+Jn50HYHdBIy1I0yx4m1cfo62VYjxB3 flpDwxzdBYDp9wCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765618381; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HVdZ5mDPLajQKLSOWxNsmmSSDODzzWGj79xvKWatIPM=; b=utcedFvi4wzoRY0sv96H8aumXKoU3yhkh0nUa4sKccl/h65zUOw1jFbArKRqmwStXLxAlF wP9wCSJ67cL/UBNUjUv64VHYPgZJTJwu2gBZermz+0dFurw67Pdda60c+THHx2Jo96U87F XMhBqS5YG883XgZK5mWzkDANJM3FDY8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765618381; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HVdZ5mDPLajQKLSOWxNsmmSSDODzzWGj79xvKWatIPM=; b=MolW6uo3BLqryx/kXs6+kTCtlIzUJCF0DXJxmtQdTBgPqHsfl5a/84TwOxqsstIaM8Vprw /XI7gT3r3ZIRN2AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 314AE3EA63; Sat, 13 Dec 2025 09:33:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8WXYCs0yPWnMKAAAD6G6ig (envelope-from ); Sat, 13 Dec 2025 09:33:01 +0000 Date: Sat, 13 Dec 2025 10:33:00 +0100 Message-ID: <87qzsy916b.wl-tiwai@suse.de> From: Takashi Iwai To: Jiapeng Chong Cc: perex@perex.cz, tiwai@suse.com, inux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH next] ALSA: hda: Remove unnecessary print function dev_err() In-Reply-To: <20251212062410.3706839-1-jiapeng.chong@linux.alibaba.com> References: <20251212062410.3706839-1-jiapeng.chong@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.1 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Flag: NO X-Spam-Score: -3.29 X-Spam-Level: X-Spamd-Result: default: False [-3.29 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.936]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,openanolis.cn:url,alibaba.com:email] On Fri, 12 Dec 2025 07:24:10 +0100, Jiapeng Chong wrote: > > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > ./sound/hda/controllers/cix-ipbloq.c:119:2-9: line 119 is redundant because platform_get_irq() already prints an error. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=28045 > Signed-off-by: Jiapeng Chong Thanks, applied. Takashi