From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C934E29A322 for ; Mon, 8 Dec 2025 08:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183943; cv=none; b=gtK4e/XeKKrj2GNgjiggV2c/Iy365BjYYbN5W5uiE5VieokTp5Mt8uHqpmj2TN3MkUalzWGdkGq/PH0Z/cWcvGrRI7b97kjVvAasdvgos5DUb7Uao/CCHAQsKDOtY6msIgJgyqTKvb1fqvc7vwVT1KQ1L5vqwxuZ7yqmK/WRTzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183943; c=relaxed/simple; bh=vLRfOCJc4nOF5GNCA/WxSk2dG3J63uLUCrbeIZ6cYCc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=RKiEkXJDU0/IlNhxPlMxEtvKcXneNB3KgXMzenTs+HUtTBqZ9+PdhcKcLKor6vg17u/EfAOhHSPeQp7utbn3iyXTCJYMqRDieue2QF9TF/a0a6B8fbBXTvaB2SAWuW71IqRO6JslELXsjnaXCFVABWVFkGUaiGECdZROyCK9JJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Fe+3Ipk8; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Fe+3Ipk8" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 64A02C1018A; Mon, 8 Dec 2025 08:51:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 17F7F60707; Mon, 8 Dec 2025 08:52:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 994FC102F0D51; Mon, 8 Dec 2025 09:52:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765183937; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=8hGarfSPljfdjvvaFqnVE6KI08H7h3+flngId20ZoOg=; b=Fe+3Ipk8XpKTyI1kzQRBgTJwr7ch6Fv7jLuiFuJP6/PjbFojHF7XZ650hakTQ81UQ213Ex kfnOjCHsXziVsUfsku+1gxx57axv1/whHQ7KYMCj+EuEAkNmzcSdVkmIJMux0Kp8qzpHew c8QF0xIiAbabh/QFOvTICf5p51yI6tCBd6GFCDu6O0MN6eL7eFj5CVaZE3vlozvlUnahyq fubhQPB/E17eCXqJko0mx6QjNNrbnITYhPOgABz0VZ0tFt9Oe04tkUDYgb/7UOR0zrkl34 tDYxbZs8jOOaq+g+GJQqngMMg4v8VDXLhuRhPRt1p9nrOhdfRGkqUD+GEF2irg== From: Miquel Raynal To: Ahmed Naseef Cc: Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: spinand: add support for Dosilicon DS35Q1GA/DS35M1GA In-Reply-To: <20251207150923.86328-1-naseefkm@gmail.com> (Ahmed Naseef's message of "Sun, 7 Dec 2025 19:09:20 +0400") References: <20251207150923.86328-1-naseefkm@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 08 Dec 2025 09:52:15 +0100 Message-ID: <87qzt573uo.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Ahmed, thanks for this contribution. > +static SPINAND_OP_VARIANTS(read_cache_variants, > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); These macros have been renamed, please rebase at -rc1. > + > +static SPINAND_OP_VARIANTS(write_cache_variants, > + SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), > + SPINAND_PROG_LOAD(true, 0, NULL, 0)); > + > +static SPINAND_OP_VARIANTS(update_cache_variants, > + SPINAND_PROG_LOAD_X4(false, 0, NULL, 0), > + SPINAND_PROG_LOAD(false, 0, NULL, 0)); > + > +static int ds35xx_ooblayout_ecc(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + return -ERANGE; > +} This is strange, there is usually some spare area used for storing the ECC. Are you sure none of the bytes in the spare area are being smashed when you write them? > +static int ds35xx_ooblayout_free(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + if (section) > + return -ERANGE; > + region->offset =3D 2; > + region->length =3D 62; > + return 0; > +} > + LGTM otherwise. Thanks, Miqu=C3=A8l