From: Nam Cao <namcao@linutronix.de>
To: Inochi Amaoto <inochiama@gmail.com>,
Inochi Amaoto <inochiama@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH] irqchip/sifive-plic: Respect mask state when setting affinity
Date: Fri, 08 Aug 2025 06:52:42 +0200 [thread overview]
Message-ID: <87qzxmpg85.fsf@yellow.woof> (raw)
In-Reply-To: <prnjyu7ev5scocf4jh5jikox3niftje364lf3bjvizppxamdov@hbizpiazqual>
Inochi Amaoto <inochiama@gmail.com> writes:
> On Fri, Aug 08, 2025 at 06:01:39AM +0800, Inochi Amaoto wrote:
> After some dig in, I found it is not very necessary to add this,
> When all enable bit is clear, the PRIORIT register of irq is
> not functional, so only umask the irq does not make sense. Only
> calling irq_enable does enable the irq.
Yeah, I contemplated doing this myself when I added the unmask to
plic_irq_enable(), because it looks more natural that plic_irq_enable()
and plic_irq_disable() are opposite. But I don't think it is necessary.
> I prefer to add a comment to describe this behavior, instead of
> adding this change in a separate patch.
No preference from me.
Nam
next prev parent reply other threads:[~2025-08-08 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 11:18 [PATCH] irqchip/sifive-plic: Respect mask state when setting affinity Inochi Amaoto
2025-08-07 12:39 ` Nam Cao
2025-08-07 22:01 ` Inochi Amaoto
2025-08-08 0:08 ` Inochi Amaoto
2025-08-08 4:52 ` Nam Cao [this message]
2025-08-08 8:29 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzxmpg85.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox