* [PATCH linux-next] drm/i915/dp: use string choice helpers
@ 2024-10-07 17:48 R Sundar
2024-10-22 10:26 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: R Sundar @ 2024-10-07 17:48 UTC (permalink / raw)
To: Jani Nikula, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Simona Vetter
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, imre.deak,
ville.syrjala, R Sundar, kernel test robot, Julia Lawall
Use str_on_off string helpers for better readability and to fix cocci
warning.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202410071252.cWILJzrH-lkp@intel.com/
Signed-off-by: R Sundar <prosunofficial@gmail.com>
---
Reported in linux repo:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/display/intel_dp.c:2243:6-9: opportunity for str_on_off(dsc)
vim +2243 drivers/gpu/drm/i915/display/intel_dp.c
compile tested only.
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index fbb096be02ad..733619b14193 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2475,7 +2475,7 @@ intel_dp_compute_config_link_bpp_limits(struct intel_dp *intel_dp,
encoder->base.base.id, encoder->base.name,
crtc->base.base.id, crtc->base.name,
adjusted_mode->crtc_clock,
- dsc ? "on" : "off",
+ str_on_off(dsc),
limits->max_lane_count,
limits->max_rate,
limits->pipe.max_bpp,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] drm/i915/dp: use string choice helpers
2024-10-07 17:48 [PATCH linux-next] drm/i915/dp: use string choice helpers R Sundar
@ 2024-10-22 10:26 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2024-10-22 10:26 UTC (permalink / raw)
To: R Sundar, Rodrigo Vivi, Joonas Lahtinen, Tvrtko Ursulin,
David Airlie, Simona Vetter
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, imre.deak,
ville.syrjala, R Sundar, kernel test robot, Julia Lawall
On Mon, 07 Oct 2024, R Sundar <prosunofficial@gmail.com> wrote:
> Use str_on_off string helpers for better readability and to fix cocci
> warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@inria.fr>
> Closes: https://lore.kernel.org/r/202410071252.cWILJzrH-lkp@intel.com/
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
Pushed to drm-intel-next, thanks for the patch.
BR,
Jani.
> ---
>
> Reported in linux repo:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> cocci warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_dp.c:2243:6-9: opportunity for str_on_off(dsc)
>
> vim +2243 drivers/gpu/drm/i915/display/intel_dp.c
>
> compile tested only.
>
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index fbb096be02ad..733619b14193 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2475,7 +2475,7 @@ intel_dp_compute_config_link_bpp_limits(struct intel_dp *intel_dp,
> encoder->base.base.id, encoder->base.name,
> crtc->base.base.id, crtc->base.name,
> adjusted_mode->crtc_clock,
> - dsc ? "on" : "off",
> + str_on_off(dsc),
> limits->max_lane_count,
> limits->max_rate,
> limits->pipe.max_bpp,
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-22 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 17:48 [PATCH linux-next] drm/i915/dp: use string choice helpers R Sundar
2024-10-22 10:26 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox