答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[胡连勤]

From: Lianqin Hu <hulianqin@vivo.com>

Audio control requests that sets sampling frequency sometimes fail on
this card. Adding delay between control messages eliminates that problem.

Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
---
v1:
  - Modify the code position and sort by ID
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index ea063a14cdd8..e7b68c67852e 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2221,6 +2221,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
 	DEVICE_FLG(0x2b53, 0x0031, /* Fiero SC-01 (firmware v1.1.0) */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
+		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x30be, 0x0101, /* Schiit Hel */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x413c, 0xa506, /* Dell AE515 sound bar */
-- 
2.39.0


-----邮件原件-----
发件人: Takashi Iwai <tiwai@suse.de> 
发送时间: 2024年8月10日 16:45
收件人: 胡连勤 <hulianqin@vivo.com>
抄送: perex@perex.cz; tiwai@suse.com; mbarriolinares@gmail.com; wangdicheng@kylinos.cn; sean@mess.org; alexander@tsoy.me; xristos.thes@gmail.com; knuesel@gmail.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>; akpm@linux-foundation.org
主题: Re: [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[You don't often get email from tiwai@suse.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Fri, 09 Aug 2024 12:38:52 +0200,
胡连勤 wrote:
>
> From: Lianqin Hu <hulianqin@vivo.com>
>
> Audio control requests that sets sampling frequency sometimes fail on 
> this card. Adding delay between control messages eliminates that problem.
>
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 
> ea063a14cdd8..4c7f0f9d15de 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2119,6 +2119,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>                  QUIRK_FLAG_GENERIC_IMPLICIT_FB),
>       DEVICE_FLG(0x07fd, 0x000b, /* MOTU M Series 2nd hardware revision */
>                  QUIRK_FLAG_CTL_MSG_DELAY_1M),
> +     DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
> +                QUIRK_FLAG_CTL_MSG_DELAY_1M),
>       DEVICE_FLG(0x08bb, 0x2702, /* LineX FM Transmitter */
>                  QUIRK_FLAG_IGNORE_CTL_ERROR),
>       DEVICE_FLG(0x0951, 0x16ad, /* Kingston HyperX */

The quirk table entry is sorted in the ID number order.
Could you try to put the new entry at the right position?


thanks,

Takashi

Re: 答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[Takashi Iwai]

On Sun, 11 Aug 2024 06:19:55 +0200,
胡连勤 wrote:
> 
> From: Lianqin Hu <hulianqin@vivo.com>
> 
> Audio control requests that sets sampling frequency sometimes fail on
> this card. Adding delay between control messages eliminates that problem.
> 
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
> v1:
>   - Modify the code position and sort by ID

A new patch shouldn't be a reply.  The Subject line contains a prefix
'答复:' which makes it invalid for tools.
Please submit from a new thread, not as a reply.


thanks,

Takashi

答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[胡连勤]

Hello linux community expert:
  
   When is this patch expected to be merged into the Linux branch?

Thanks

-----邮件原件-----
发件人: 胡连勤 
发送时间: 2024年8月12日 16:19
收件人: Takashi Iwai <tiwai@suse.de>
抄送: perex@perex.cz; tiwai@suse.com; mbarriolinares@gmail.com; wangdicheng@kylinos.cn; sean@mess.org; alexander@tsoy.me; xristos.thes@gmail.com; knuesel@gmail.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>; akpm@linux-foundation.org
主题: Re: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

Hello  linux community expert:

  OK.

Thanks

-----邮件原件-----
发件人: Takashi Iwai <tiwai@suse.de>
发送时间: 2024年8月12日 15:23
收件人: 胡连勤 <hulianqin@vivo.com>
抄送: perex@perex.cz; tiwai@suse.com; mbarriolinares@gmail.com; wangdicheng@kylinos.cn; sean@mess.org; alexander@tsoy.me; xristos.thes@gmail.com; knuesel@gmail.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>; akpm@linux-foundation.org
主题: Re: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[You don't often get email from tiwai@suse.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Sun, 11 Aug 2024 10:30:11 +0200,
胡连勤 wrote:
>
> From: Lianqin Hu <hulianqin@vivo.com>
>
> Audio control requests that sets sampling frequency sometimes fail on 
> this card. Adding delay between control messages eliminates that problem.
>
> Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> ---
> v1:
>   - Modify the code position and sort by ID

Thanks, applied to for-linus branch now.


Takashi