Re: [PATCH v2 08/16] docs: Add XZ_EXTERN to c_id_attributes

Jonathan Corbet
2024-07-21T23:16:40Z

Lasse Collin <lasse.collin@tukaani.org> writes:

> include/linux/xz.h uses XZ_EXTERN in function prototypes. It's needed in
> the preboot code. Adding XZ_EXTERN c_id_attributes silences warnings and
> makes the intradocument links to the xz_dec functions work.
>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Reviewed-by: Sam James <sam@gentoo.org>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> ---
> Documentation/conf.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index 0c2205d536b3..2fc1fea858e1 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -123,6 +123,9 @@ if major >= 3:
>
> # include/linux/btf.h
> "__bpf_kfunc",
> +
> + # include/linux/xz.h
> + "XZ_EXTERN",
> ]

I spent a little while trying to figure out why we need XZ_EXTERN at all
but lost in the #includes... Oh well. For the purposes of the docs
build:

Acked-by: Jonathan Corbet <corbet@lwn.net>

Thanks,

jon