* [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers
@ 2024-04-22 14:33 Andy Shevchenko
2024-04-22 18:49 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-04-22 14:33 UTC (permalink / raw)
To: Melissa Wen, dri-devel, linux-kernel
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use)
principle.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/drm/drm_fixed.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
index 81572d32db0c..387fb81d5b81 100644
--- a/include/drm/drm_fixed.h
+++ b/include/drm/drm_fixed.h
@@ -25,8 +25,9 @@
#ifndef DRM_FIXED_H
#define DRM_FIXED_H
-#include <linux/kernel.h>
#include <linux/math64.h>
+#include <linux/types.h>
+#include <linux/wordpart.h>
typedef union dfixed {
u32 full;
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers
2024-04-22 14:33 [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers Andy Shevchenko
@ 2024-04-22 18:49 ` Jani Nikula
2024-04-25 17:12 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2024-04-22 18:49 UTC (permalink / raw)
To: Andy Shevchenko, Melissa Wen, dri-devel, linux-kernel
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, Andy Shevchenko
On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Assuming it builds, and nothing depends on other stuff from kernel.h via
drm_fixed.h,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_fixed.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
> index 81572d32db0c..387fb81d5b81 100644
> --- a/include/drm/drm_fixed.h
> +++ b/include/drm/drm_fixed.h
> @@ -25,8 +25,9 @@
> #ifndef DRM_FIXED_H
> #define DRM_FIXED_H
>
> -#include <linux/kernel.h>
> #include <linux/math64.h>
> +#include <linux/types.h>
> +#include <linux/wordpart.h>
>
> typedef union dfixed {
> u32 full;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers
2024-04-22 18:49 ` Jani Nikula
@ 2024-04-25 17:12 ` Andy Shevchenko
2024-08-13 8:41 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-04-25 17:12 UTC (permalink / raw)
To: Jani Nikula
Cc: Melissa Wen, dri-devel, linux-kernel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote:
> On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Assuming it builds, and nothing depends on other stuff from kernel.h via
> drm_fixed.h,
For the record, I have built-tested this via `make allyesconfig` on x86_64.
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers
2024-04-25 17:12 ` Andy Shevchenko
@ 2024-08-13 8:41 ` Andy Shevchenko
2024-08-13 10:25 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-08-13 8:41 UTC (permalink / raw)
To: Jani Nikula
Cc: Melissa Wen, dri-devel, linux-kernel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote:
> > On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > Update header inclusions to follow IWYU (Include What You Use)
> > > principle.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Assuming it builds, and nothing depends on other stuff from kernel.h via
> > drm_fixed.h,
>
> For the record, I have built-tested this via `make allyesconfig` on x86_64.
>
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Thank you!
Who is going to apply this, please?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers
2024-08-13 8:41 ` Andy Shevchenko
@ 2024-08-13 10:25 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2024-08-13 10:25 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Melissa Wen, dri-devel, linux-kernel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
On Tue, 13 Aug 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote:
>> On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote:
>> > On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>> > > Update header inclusions to follow IWYU (Include What You Use)
>> > > principle.
>> > >
>> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> >
>> > Assuming it builds, and nothing depends on other stuff from kernel.h via
>> > drm_fixed.h,
>>
>> For the record, I have built-tested this via `make allyesconfig` on x86_64.
>>
>> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Thank you!
>
> Who is going to apply this, please?
Pushed to drm-misc-next, thanks for the patch.
BR,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-13 10:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 14:33 [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers Andy Shevchenko
2024-04-22 18:49 ` Jani Nikula
2024-04-25 17:12 ` Andy Shevchenko
2024-08-13 8:41 ` Andy Shevchenko
2024-08-13 10:25 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox