From: Sergey Organov <sorganov@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Esben Haabendal <esben@geanix.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] serial: imx: Introduce timeout when waiting on transmitter empty
Date: Fri, 05 Apr 2024 22:05:59 +0300 [thread overview]
Message-ID: <87r0fj1vfs.fsf@osv.gnss.ru> (raw)
In-Reply-To: <CAOMZO5Axz7un+9H2uEoQtE0=pYNC0hEyZiNobrSi2m0ajj8N+g@mail.gmail.com> (Fabio Estevam's message of "Fri, 5 Apr 2024 14:38:48 -0300")
Fabio Estevam <festevam@gmail.com> writes:
> On Fri, Apr 5, 2024 at 6:25 AM Esben Haabendal <esben@geanix.com> wrote:
>>
>> By waiting at most 1 second for USR2_TXDC to be set, we avoid a potentital
>
> s/potentital/potential
>
> Could you elaborate on this deadlock? Have you seen it in practice?
I've stumped upon this piece of code a long time ago, and it's indeed
broken. However, to actually see a "deadlock", I believe one needs to
enable hardware RTS/CTS handshake on the port, then, say, not connect
RS232 cable, and then printk(), if enabled to this port, will soon
result in the loop to be executed forever, that in turn will hang
single-CPU machine entirely (provided this code is still executed with
interrupts disabled, as it was at the time I investigated severe
printk()-induced ISR delays).
-- Sergey Organov
next prev parent reply other threads:[~2024-04-05 19:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 9:25 [PATCH 1/2] serial: imx: Introduce timeout when waiting on transmitter empty Esben Haabendal
2024-04-05 9:49 ` Marc Kleine-Budde
2024-04-05 17:22 ` Esben Haabendal
2024-04-05 17:33 ` Marc Kleine-Budde
2024-04-08 8:57 ` Esben Haabendal
2024-04-05 17:38 ` Fabio Estevam
2024-04-05 19:05 ` Sergey Organov [this message]
2024-04-08 8:56 ` Esben Haabendal
2024-04-10 7:18 ` [PATCH v2] " Esben Haabendal
2024-04-11 12:06 ` Greg Kroah-Hartman
2024-04-11 12:18 ` Esben Haabendal
2024-04-11 12:19 ` [PATCH v3] " Esben Haabendal
2024-05-02 9:14 ` Esben Haabendal
2024-05-04 16:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0fj1vfs.fsf@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=esben@geanix.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox