* [PATCH -next] fs: Add kernel-doc comments to fat_parse_long()
@ 2024-03-15 7:52 Yang Li
2024-03-15 13:28 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-03-15 7:52 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Yang Li
This commit adds kernel-doc style comments with complete parameter
descriptions for the function fat_parse_long.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/fat/dir.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 00235b8a1823..8236807eb7f7 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -269,6 +269,16 @@ enum { PARSE_INVALID = 1, PARSE_NOT_LONGNAME, PARSE_EOF, };
/**
* fat_parse_long - Parse extended directory entry.
*
+ * @dir: Pointer to the inode that represents the directory.
+ * @pos: On input, contains the starting position to read from.
+ * On output, updated with the new position.
+ * @bh: Pointer to the buffer head that may be used for reading directory entries.
+ * May be updated.
+ * @de: On input, points to the current directory entry.
+ * On output, points to the next directory entry.
+ * @unicode: Pointer to a buffer where the parsed Unicode long filename will be stored.
+ * @nr_slots: Pointer to a variable that will store the number of longname slots found.
+ *
* This function returns zero on success, negative value on error, or one of
* the following:
*
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] fs: Add kernel-doc comments to fat_parse_long()
2024-03-15 7:52 [PATCH -next] fs: Add kernel-doc comments to fat_parse_long() Yang Li
@ 2024-03-15 13:28 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2024-03-15 13:28 UTC (permalink / raw)
To: Yang Li; +Cc: linux-kernel
Yang Li <yang.lee@linux.alibaba.com> writes:
> + * @bh: Pointer to the buffer head that may be used for reading directory entries.
> + * May be updated.
> + * @de: On input, points to the current directory entry.
> + * On output, points to the next directory entry.
> + * @unicode: Pointer to a buffer where the parsed Unicode long filename will be stored.
> + * @nr_slots: Pointer to a variable that will store the number of longname slots found.
> + *
> * This function returns zero on success, negative value on error, or one of
> * the following:
> *
Beyond 80 columns is common now?
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-15 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-15 7:52 [PATCH -next] fs: Add kernel-doc comments to fat_parse_long() Yang Li
2024-03-15 13:28 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox