* [PATCH] drm/edid: Clean up errors in drm_edid.h
@ 2024-01-11 6:39 chenxuebing
2024-01-11 10:02 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: chenxuebing @ 2024-01-11 6:39 UTC (permalink / raw)
To: daniel, airlied, mripard, maarten.lankhorst, tzimmermann
Cc: linux-kernel, dri-devel, chenxuebing
Fix the following errors reported by checkpatch:
ERROR: do not use assignment in if condition
Signed-off-by: chenxuebing <chenxb_99091@126.com>
---
drivers/gpu/drm/drm_edid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 69c68804023f..9bcaf76f10fc 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
if (!mode_in_vsync_range(mode, edid, t))
return false;
- if ((max_clock = range_pixel_clock(edid, t)))
+ max_clock = range_pixel_clock(edid, t);
+ if (max_clock)
if (mode->clock > max_clock)
return false;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: Clean up errors in drm_edid.h
2024-01-11 6:39 [PATCH] drm/edid: Clean up errors in drm_edid.h chenxuebing
@ 2024-01-11 10:02 ` Jani Nikula
2024-01-11 14:50 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2024-01-11 10:02 UTC (permalink / raw)
To: chenxuebing, daniel, airlied, mripard, maarten.lankhorst,
tzimmermann
Cc: linux-kernel, dri-devel, chenxuebing
On Thu, 11 Jan 2024, chenxuebing <chenxb_99091@126.com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: chenxuebing <chenxb_99091@126.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 69c68804023f..9bcaf76f10fc 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
> if (!mode_in_vsync_range(mode, edid, t))
> return false;
>
> - if ((max_clock = range_pixel_clock(edid, t)))
> + max_clock = range_pixel_clock(edid, t);
> + if (max_clock)
> if (mode->clock > max_clock)
> return false;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/edid: Clean up errors in drm_edid.h
2024-01-11 10:02 ` Jani Nikula
@ 2024-01-11 14:50 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2024-01-11 14:50 UTC (permalink / raw)
To: chenxuebing, daniel, airlied, mripard, maarten.lankhorst,
tzimmermann
Cc: linux-kernel, dri-devel, chenxuebing
On Thu, 11 Jan 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 11 Jan 2024, chenxuebing <chenxb_99091@126.com> wrote:
>> Fix the following errors reported by checkpatch:
>>
>> ERROR: do not use assignment in if condition
>>
>> Signed-off-by: chenxuebing <chenxb_99091@126.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
And pushed to drm-misc-next, thanks for the patch.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_edid.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 69c68804023f..9bcaf76f10fc 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
>> if (!mode_in_vsync_range(mode, edid, t))
>> return false;
>>
>> - if ((max_clock = range_pixel_clock(edid, t)))
>> + max_clock = range_pixel_clock(edid, t);
>> + if (max_clock)
>> if (mode->clock > max_clock)
>> return false;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-11 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 6:39 [PATCH] drm/edid: Clean up errors in drm_edid.h chenxuebing
2024-01-11 10:02 ` Jani Nikula
2024-01-11 14:50 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox